Revert r318180 and re-enable AIO tests on md(4) by default. The 'physio' fast-path used by AIO requests on md(4) devices, is not gated on the unsafe_aio knob. Prior to r327755, some AIO requests could fail the fast-path and fall back to the slow...
ClosedPublic
Actions

Authored by jhb on Mar 19 2018, 5:47 PM.

Details

Reviewers

Commits

rS331221: Revert r318180 and re-enable AIO tests on md(4) by default.

Summary

...-path (requests for devices
not supporting unmapped I/O and requests which failed with EFAULT during
the fast-path). However, those cases now return a suitable error rather
than using the slow-path.

PR: 217261

Test Plan

was never able to reproduce the original failures reported in Jenkins even with extra test programs

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 19 2018, 5:47 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 19 2018, 5:47 PM

Harbormaster completed remote builds in B15648: Diff 40454.Mar 19 2018, 5:47 PM

asomers accepted this revision.Mar 19 2018, 6:08 PM

This revision is now accepted and ready to land.Mar 19 2018, 6:08 PM

Closed by commit rS331221: Revert r318180 and re-enable AIO tests on md(4) by default. (authored by jhb). · Explain WhyMar 19 2018, 7:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

tests/

sys/

aio/

aio_test.c

1 line

Diff 40476

View Options

head/tests/sys/aio/aio_test.c

Revert r318180 and re-enable AIO tests on md(4) by default. The 'physio' fast-path used by AIO requests on md(4) devices, is not gated on the unsafe_aio knob. Prior to r327755, some AIO requests could fail the fast-path and fall back to the slow...ClosedPublicActions