Page MenuHomeFreeBSD
Differential D14661

New Mk/Uses/lazarus.mk
ClosedPublic
Actions

Authored by acm on Mar 11 2018, 9:48 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Dec 22, 6:28 PM
Unknown Object (File)
Sat, Dec 21, 4:36 PM
Unknown Object (File)
Sat, Dec 21, 4:16 PM
Unknown Object (File)
Tue, Dec 10, 4:38 PM
Unknown Object (File)
Mon, Dec 9, 3:34 PM
Unknown Object (File)
Sun, Dec 8, 3:54 AM
Unknown Object (File)
Sun, Dec 8, 3:23 AM
Unknown Object (File)
Thu, Dec 5, 5:10 PM
View All Files
Subscribers
antoine
mat
rigoletto
portmgr

Details

Reviewers
mat
Group Reviewers
portmgr
Commits
rP470851: - Moved ports to Uses/lazarus.mk
rP470850: - Add entries of lazarus-lcl-gtk2, lazarus-lcl-nogui lazarus-lcl-qt
rP470849: - Remove obsolete ports (lazarus-lcl-gtk2, lazarus-lcl-nogui lazarus-lcl-qt
rP470848: - Update to 3.6.4
rP470847: - New port: editors/lazarus-qt5
rP470846: - New port: editors/lazarus-qt4
rP470845: - Update to 1.8.2
Summary

It introduces Uses/lazarus.mk and move all lazarus-based ports to USES=lazarus

Test Plan

Tested on head

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

acm created this revision.Mar 11 2018, 9:48 PM
Herald added 1 blocking reviewer(s): portmgr. · View Herald TranscriptMar 11 2018, 9:48 PM
Herald added a subscriber: mat. · View Herald Transcript
acm updated this revision to Diff 40183.Mar 11 2018, 9:58 PM
  • Remove fpc from USES. It is not committed yet
mat added inline comments.Mar 12 2018, 10:20 AM
Mk/Uses/lazarus.mk
73

You cannot add to USES in a uses.

74–75

You cannot add to variables used by other uses in a uses. Especially as they will run before this is ever executed.

acm updated this revision to Diff 40196.Mar 12 2018, 3:16 PM
acm marked 2 inline comments as done.
  • Remove USES/USE variables from lazarus.mk
mat added inline comments.Mar 12 2018, 3:54 PM
Mk/Uses/lazarus.mk
108–109

maybe fold those two conditions on one line.

rigoletto added a subscriber: rigoletto.Mar 13 2018, 3:01 PM
acm updated this revision to Diff 41073.Apr 4 2018, 6:48 AM
  • Prepare for USES=fpc support
acm updated this revision to Diff 41195.Apr 6 2018, 6:46 PM
  • Add FLAVORS support
  • Switch lazarus-based ports to FLAVORS
  • Other minor modifications
acm updated this revision to Diff 41205.Apr 6 2018, 8:37 PM
  • Add flavor_CONFLICTS_INSTALL
  • Other minor modifications
acm updated this revision to Diff 41229.Apr 7 2018, 1:05 PM
  • Add missing dependencies
acm added a comment.EditedApr 7 2018, 10:56 PM

poudriere logs on 11.1-amd64

https://people.freebsd.org/~acm/ports/logs/WinFF-gtk2-1.5.5_8.log
https://people.freebsd.org/~acm/ports/logs/WinFF-qt4-1.5.5_8.log
https://people.freebsd.org/~acm/ports/logs/coedit-gtk2-3.6.4.log
https://people.freebsd.org/~acm/ports/logs/coedit-qt4-3.6.4.log
https://people.freebsd.org/~acm/ports/logs/coedit-qt5-3.6.4.log
https://people.freebsd.org/~acm/ports/logs/cqrlog-gtk2-2.2.0_1.log
https://people.freebsd.org/~acm/ports/logs/cqrlog-qt4-2.2.0_1.log
https://people.freebsd.org/~acm/ports/logs/doublecmd-gtk2-0.8.2.log
https://people.freebsd.org/~acm/ports/logs/doublecmd-qt4-0.8.2.log
https://people.freebsd.org/~acm/ports/logs/lazarus-gtk2-1.8.2.log
https://people.freebsd.org/~acm/ports/logs/lazarus-qt4-1.8.2.log
https://people.freebsd.org/~acm/ports/logs/lazarus-qt5-1.8.2.log
https://people.freebsd.org/~acm/ports/logs/peazip-gtk2-6.5.1.log
https://people.freebsd.org/~acm/ports/logs/peazip-qt4-6.5.1.log
https://people.freebsd.org/~acm/ports/logs/peazip-qt5-6.5.1.log
https://people.freebsd.org/~acm/ports/logs/ru-emkatic-gtk2-0.36.log
https://people.freebsd.org/~acm/ports/logs/ru-emkatic-qt4-0.36.log
https://people.freebsd.org/~acm/ports/logs/ru-emkatic-qt5-0.36.log
https://people.freebsd.org/~acm/ports/logs/transmission-remote-gui-gtk2-5.14.0.log
https://people.freebsd.org/~acm/ports/logs/transmission-remote-gui-qt4-5.14.0.log
https://people.freebsd.org/~acm/ports/logs/transmission-remote-gui-qt5-5.14.0.log
https://people.freebsd.org/~acm/ports/logs/zcad-gtk2-0.9.8_1.log
https://people.freebsd.org/~acm/ports/logs/zcad-qt4-0.9.8_1.log

acm updated this revision to Diff 41246.Apr 8 2018, 1:13 AM
  • Add entries to MOVED file
  • Fix build of cqrlog-qt4
mat added inline comments.Apr 11 2018, 2:35 PM
MOVED
10255–10258 ↗(On Diff #41246)

The second field is where you tell software what to use instead.

archivers/peazip/Makefile
7

I would prefer that you do as php or python flavors do, have USES=lazarus generate a LAZARUS_PKGNAMESUFFIX/PREFIX and use it in ports.

acm updated this revision to Diff 41383.Apr 11 2018, 9:44 PM
  • Fix MOVED
  • Respect DEBUG on x11-fm/doublecmd
  • Add LAZARUS_PKGNAMESUFFIX
acm marked 2 inline comments as done.Apr 11 2018, 9:45 PM
mat added inline comments.Apr 12 2018, 11:03 AM
archivers/peazip/Makefile
28–29

Remove -*.

42–43

This is always true.

acm updated this revision to Diff 41443.Apr 13 2018, 6:28 PM
  • Remove characters from flavor_CONFLICTS_INSTALL
  • Fix FLAVOR conditional into some ports
acm marked 2 inline comments as done.Apr 13 2018, 6:28 PM
acm updated this revision to Diff 41478.Apr 15 2018, 5:39 AM
  • Remove duplicate lines from Uses/lazarus.mk
acm added a comment.May 18 2018, 4:36 PM

any news about it?

mat accepted this revision.May 25 2018, 2:23 PM

This looks ok now. Sorry for the delay.

If there was an exp-run and it passed, feel free to commit it.

This revision is now accepted and ready to land.May 25 2018, 2:23 PM
Closed by commit rP470845: - Update to 1.8.2 (authored by acm). · Explain WhyMay 25 2018, 3:57 PM
This revision was automatically updated to reflect the committed changes.
antoine added a subscriber: antoine.May 26 2018, 6:28 PM

It seems doublecmd-gtk2 fails to package:
http://beefy9.nyi.freebsd.org/data/111amd64-default/470877/logs/errors/doublecmd-gtk2-0.8.2.log

Revision Contents
Changeset List

PathSize
Mk/
Uses/
138 lines
archivers/
peazip/
57 lines
6 lines
cad/
zcad/
49 lines
files/
2 lines
comms/
cqrlog/
37 lines
files/
4 lines
editors/
7 lines
coedit/
59 lines
6 lines
files/
24 lines
lazarus-lcl-gtk2/
18 lines
lazarus-lcl-nogui/
18 lines
lazarus-lcl-qt/
17 lines
files/
11 lines
lazarus-lcl-qt5/
17 lines
files/
11 lines
lazarus-lcl-units/
17 lines
lazarus-qt4/
190 lines
lazarus-qt5/
191 lines
lazarus/
82 lines
104 lines
6 lines
files/
15 lines
20 lines
9 lines
multimedia/
winff/
49 lines
files/
19 lines
net-p2p/
transmission-remote-gui/
63 lines
5 lines
2 lines
russian/
emkatic/
39 lines
6 lines
x11-fm/
doublecmd/
141 lines
6 lines

Diff 41205

View Options

Mk/Uses/lazarus.mk

Loading...
View Options

archivers/peazip/Makefile

Loading...
View Options

archivers/peazip/distinfo

Loading...
View Options

cad/zcad/Makefile

Loading...
View Options

cad/zcad/files/makefile

Loading...
View Options

comms/cqrlog/Makefile

Loading...
View Options

comms/cqrlog/files/patch-Makefile

Loading...
View Options

editors/Makefile

Loading...
View Options

editors/coedit/Makefile

Loading...
View Options

editors/coedit/distinfo

Loading...
View Options

editors/coedit/files/patch-dastworx_build.sh

Loading...
View Options

editors/lazarus-lcl-gtk2/Makefile

Loading...
View Options

editors/lazarus-lcl-nogui/Makefile

Loading...
View Options

editors/lazarus-lcl-qt/Makefile

Loading...
View Options

editors/lazarus-lcl-qt/files/patch-interfaces_qt_qt45.pas

Loading...
View Options

editors/lazarus-lcl-qt5/Makefile

Loading...
View Options

editors/lazarus-lcl-qt5/files/patch-interfaces_qt_qt45.pas

Loading...
View Options

editors/lazarus-lcl-units/Makefile

Loading...
View Options

editors/lazarus-qt4/Makefile

Loading...
View Options

editors/lazarus-qt5/Makefile

Loading...
View Options

editors/lazarus/Makefile

Loading...
View Options

editors/lazarus/Makefile.common

Loading...
View Options

editors/lazarus/distinfo

Loading...
View Options

editors/lazarus/files/patch-Makefile

Loading...
View Options

editors/lazarus/files/patch-components-synedit_synedit.pp

Loading...
View Options

editors/lazarus/files/pkg-message.in

Loading...
View Options

multimedia/winff/Makefile

Loading...
View Options

multimedia/winff/files/patch-winff_unit1.pas

Loading...
View Options

net-p2p/transmission-remote-gui/Makefile

Loading...
View Options

net-p2p/transmission-remote-gui/distinfo

Loading...
View Options

net-p2p/transmission-remote-gui/pkg-descr

Loading...
View Options

russian/emkatic/Makefile

Loading...
View Options

russian/emkatic/distinfo

Loading...
View Options

x11-fm/doublecmd/Makefile

Loading...
View Options

x11-fm/doublecmd/distinfo

Loading...