Page MenuHomeFreeBSD

Update multimedia/*phonon* and flavorize
ClosedPublic

Authored by tcberner on Mar 9 2018, 7:10 PM.

Details

Summary

There was a new phonon and phonon-backend-vlc release recently.

Maybe these ports should be further simplified while here... sharing distinfo and such.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 15451
Build 15497: arc lint + arc unit

Event Timeline

Couldn't the qt4/qt5 ports be merged and use flavors to select qt4/qt5?

Yeah, I was also thinking about that. Will do :)

I'll add the bumps once this part is reviewed to keep it a bit more readable.

multimedia/phonon/pkg-plist.qt5
1 ↗(On Diff #40130)

I think I can unite the plists with something a PLIST_SUB set to 4qt5 resp ""

Finish flavorization of phonon ports.

tcberner retitled this revision from Update multimedia/*phonon* to Update multimedia/*phonon* and flavorize.Apr 29 2018, 10:39 AM
multimedia/phonon-designerplugin/Makefile
8

We prefer to have PKGNAMESUFFIX be statically defined using the helpers:

qt4_PKGNAMESUFFIX=  -designerplugin-qt4
qt5_PKGNAMESUFFIX=  -designerplugin-qt5
multimedia/phonon-gstreamer/Makefile
9 ↗(On Diff #43889)

Same here,

qt4_PKGNAMESUFFIX=  -${PHONON_PLUGIN}-qt4
qt5_PKGNAMESUFFIX=  -${PHONON_PLUGIN}-qt5
multimedia/phonon/Makefile
8

Same.

Use helper to set PKGNAMESUFFIX

Fix phonon-designerplugins' PKGNAMESUFFIX

Flavors look right, do make sure this is test built :-p

This revision was not accepted when it landed; it landed in state Needs Review.Jul 11 2018, 4:56 AM
This revision was automatically updated to reflect the committed changes.