Page MenuHomeFreeBSD

Add test for regression fixed in r329743
Needs ReviewPublic

Authored by rstone on Mar 1 2018, 9:37 PM.

Details

Reviewers
asomers
Summary

In r264986, the behaviour of route(8) regresssed and it became
no longer possible to modify a route via "route change" unless
you explicitly specified the route's gateway. Add an explicit
test for this behaviour to ensure that this doesn't happen again.

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 15565
Build 15602: arc lint + arc unit

Event Timeline

rstone created this revision.Mar 1 2018, 9:37 PM
asomers requested changes to this revision.Mar 1 2018, 10:01 PM

Most of the other tests in this file relate specifically to multifib functionality. I think your test should go into a new file. You can pull the helper routines out into a .subr file.

This revision now requires changes to proceed.Mar 1 2018, 10:01 PM
rstone updated this revision to Diff 40292.Mar 14 2018, 7:03 PM

Move non-fib test into separate test file

Where is route.subr? And where did ipv4_move_subnet_route come from? I think you used the wrong base revision to generate the review.

Where is route.subr? And where did ipv4_move_subnet_route come from? I think you used the wrong base revision to generate the review.

This based off of the change in https://reviews.freebsd.org/D14547

Why don't you just combine this review with that one? It would be easier to review that way.