mail/rspamd: Backport the upstream patch fixing reject-message with FreeBSD's libmilter
ClosedPublic
Actions

Authored by mmokhi on Feb 28 2018, 3:38 PM.

Details

Reviewers: None
Commits: rP463669: mail/rspamd: Backport upstream patch for reject-message with FreeBSD libmilter

Summary

There was a bug in upstream's compatibility with FreeBSD's libmilter (here) that causes rspamd to send reject messages after set reply.

the patch fixes it.

(maintainer @vsevolod is CC'd)

Test Plan

poudriere builds fine.
Tested on Netzkommune GmbH machine setup in action.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 15312
Build 15370: arc lint + arc unit

Event Timeline

mmokhi created this revision.Feb 28 2018, 3:38 PM

mmokhi created this object with visibility "All Users".

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptFeb 28 2018, 3:38 PM

Are all those debug messages really part of the fix for the problem?

In D14542#305041, @mat wrote:

Are all those debug messages really part of the fix for the problem?

Well I got the patch from a commit on the Github repo, I personally don't think debug-messages are a fix, but I preferred to keep them as the upstream devs did.

mmokhi edited the test plan for this revision. (Show Details)Mar 1 2018, 12:52 PM

mmokhi changed the visibility from "All Users" to "Public (No Login Required)".Mar 1 2018, 7:23 PM

Approved by maintainer via email 🙂

This revision was not accepted when it landed; it landed in state Needs Review.Mar 5 2018, 9:00 PM

Closed by commit rP463669: mail/rspamd: Backport upstream patch for reject-message with FreeBSD libmilter (authored by mmokhi). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

mail/

rspamd/

Makefile

2 lines

files/

patch-src_libserver_milter.c

113 lines

Diff 39828

View Options

mail/rspamd/Makefile