Page MenuHomeFreeBSD

audio/musicpc: Update to 0.29
ClosedPublic

Authored by yuri on Feb 27 2018, 8:15 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuri created this revision.Feb 27 2018, 8:15 AM
yuri added a comment.Feb 27 2018, 8:17 AM

Hi @mat,

This port builds man pages using textproc/py-sphinx. It should be possible to turn off such external dependency.
Is MANPAGES option okay here?

Yuri

mat added inline comments.Feb 27 2018, 3:52 PM
audio/musicpc/Makefile
27 ↗(On Diff #39786)

Specifying an executable on a flavored port is a bad idea, it will only exist for the default flavor. It would be preferable to depend on the package being installed.

yuri updated this revision to Diff 39799.Feb 27 2018, 4:52 PM

How about this?

mat added a comment.Feb 27 2018, 5:06 PM
In D14531#304761, @yuri wrote:

How about this?

This is a nice new way of doing it. Now, could you possibly do it like every python port flavored dependency, with the package?

I keep wondering why you make it so difficult for everyone to help you fit in. Always trying to find a new way to not do what is asked of you.

yuri marked an inline comment as done.Feb 27 2018, 5:28 PM
In D14531#304784, @mat wrote:
In D14531#304761, @yuri wrote:

How about this?

This is a nice new way of doing it. Now, could you possibly do it like every python port flavored dependency, with the package?
I keep wondering why you make it so difficult for everyone to help you fit in. Always trying to find a new way to not do what is asked of you.

Some people call it creativity. :)


Please note that 5.9.3. BUILD_DEPENDS only says This variable specifies executables or files this port requires to build. Package syntax needs to be added there, because it is missing. It might also be a good idea to add more examples there to illustrate all possible use types.

I literally read and followed it without referring to anything else.

audio/musicpc/Makefile
27 ↗(On Diff #39786)

How can BUILD_DEPENDS depend on a package?

mat added inline comments.Feb 27 2018, 5:50 PM
audio/musicpc/Makefile
27 ↗(On Diff #39786)

Like you have done for the gazillion python modules you added, look at any of BUILD/RUN_DEPENDS lines.

It is explained in 5.9.9.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 27 2018, 6:52 PM
Closed by commit rP463151: audio/musicpc: Update to 0.29 (authored by yuri). · Explain Why
This revision was automatically updated to reflect the committed changes.
yuri marked an inline comment as done.