Page MenuHomeFreeBSD

Improve autofs documentation.
ClosedPublic

Authored by trasz on Jan 6 2015, 5:58 PM.
Tags
None
Referenced Files
F103528666: D1447.id.diff
Tue, Nov 26, 3:38 AM
Unknown Object (File)
Sun, Oct 27, 12:23 PM
Unknown Object (File)
Oct 4 2024, 12:38 AM
Unknown Object (File)
Oct 2 2024, 8:09 AM
Unknown Object (File)
Oct 2 2024, 5:43 AM
Unknown Object (File)
Sep 28 2024, 5:55 AM
Unknown Object (File)
Sep 27 2024, 7:36 AM
Unknown Object (File)
Sep 20 2024, 12:42 PM

Details

Reviewers
wblock
Group Reviewers
Doc Committers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

trasz retitled this revision from to Improve autofs documentation..
trasz updated this object.
trasz edited the test plan for this revision. (Show Details)
brueffer added inline comments.
usr.sbin/autofs/auto_master.5
30

Leading 0 should be removed.

184

The .Pp should be before .Bl

187

This (and the ones below) should be marked up differently... With .Li perhaps? Either way, there needs to be a space between the terminating . and the preceeding stuff.

wblock added inline comments.
usr.sbin/autofs/auto_master.5
186

s/Expanded/Expands/
Also in the next variables.

204

Additional variables can be defined with the

206

"to" is a little unclear there, whether it is being sent "to" that program or the option of that program. Probably this can just be "of".

258

A little confusing.

Directories for individual NFS servers are not present until the first access, when they are automatically created.

270

maps named
.Pa special_foo ,
to the

278

has the execute bit set,

283

Comma is not needed.

284

newline characters.

287

This is two sentences. The first is clear:

Otherwise, the executable will be called with a key name as
a command line argument.

The second is less clear. Maybe

Output from the executable is expected to be the entry for that key.

(Not sure about specifying leaving the key out, that seems reasonably clear, but an example might be good.)

usr.sbin/autofs/auto_master.5
278

The last "the" on this line should be removed:

has the execute bit set,

288

How about:

not including the key itself.

usr.sbin/autofs/auto_master.5
357

Should this be "services"? Could be more than LDAP in the future...

wblock added a reviewer: wblock.

Looks good to me.

This revision is now accepted and ready to land.Jan 9 2015, 12:42 AM