Page MenuHomeFreeBSD

Prevent savecore from reading bounds from the current directory.
ClosedPublic

Authored by silby on Feb 15 2018, 7:51 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 5 2024, 5:49 PM
Unknown Object (File)
Nov 1 2024, 11:48 PM
Unknown Object (File)
Nov 1 2024, 11:06 PM
Unknown Object (File)
Nov 1 2024, 11:06 PM
Unknown Object (File)
Nov 1 2024, 11:06 PM
Unknown Object (File)
Nov 1 2024, 10:43 PM
Unknown Object (File)
Sep 24 2024, 5:42 PM
Unknown Object (File)
Sep 24 2024, 5:42 PM
Subscribers

Details

Summary

Prevent savecore from reading bounds from the current directory.

Rev 244218 removed the requirement that you provide a dump
directory when checking if there is a coredump ready to be written.
That had the side-effect of causing the bounds file to be read
from the current working directory instead of the dump directory.
As the bounds file is irrelevant when just checking, the simplest
fix is to not read the bounds file when checking.

Test Plan

Confirm that savecore is still able to check for core files.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj added inline comments.
sbin/savecore/savecore.c
180 ↗(On Diff #39335)

Style: parens around the return value.

This revision is now accepted and ready to land.Feb 15 2018, 3:03 PM
This revision now requires review to proceed.Feb 16 2018, 12:21 AM
This revision is now accepted and ready to land.Feb 16 2018, 12:35 AM
This revision was automatically updated to reflect the committed changes.