security/bro: Add a NETMAP option to build and install the bro netmap plugin
ClosedPublic
Actions

Authored by leres on Feb 14 2018, 11:37 PM.

Details

Reviewers

ler
matthew
mat

Commits

rP463362: MFH: r461924 r462351 r462460
rP462351: Add a NETMAP option to build and install the bro netmap plugin.

Summary

Proposed commit message:

Add a NETMAP option to build and install the bro netmap plugin.

PR: 224918
Reported by: Shane Peters
Reviewed by: ? (mentor)
Approved by: ? (mentor)
Differential Revision: ?

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

leres created this revision.Feb 14 2018, 11:37 PM

Herald added a subscriber: mat. · View Herald TranscriptFeb 14 2018, 11:37 PM

Harbormaster completed remote builds in B15053: Diff 39325.Feb 14 2018, 11:37 PM

Looks ok to me, but I'd like to see @matthew look at it too before you commit it.

This revision is now accepted and ready to land.Feb 14 2018, 11:55 PM

mat requested changes to this revision.Feb 15 2018, 1:20 PM

mat added inline comments.

security/bro/Makefile
9–10 ↗	(On Diff #39325)	USE_GITHUB for both of those.

This revision now requires changes to proceed.Feb 15 2018, 1:20 PM

Redo NETMAP changes to use GH_TUPLE (thanks to @mat for providing
an example by changing BROKER to work this way). Only download caf
and bro-netmap when they are enabled.

Harbormaster completed remote builds in B15066: Diff 39341.Feb 15 2018, 6:05 PM

lgtm

mat added inline comments.Feb 16 2018, 10:39 AM

security/bro/Makefile
22–23 ↗	(On Diff #39341)	Those should go with the other options helpers. And `USE_GITHUB` should probably only be defined when one of the option is enabled. BROKER_USE= GITHUB=nodefault NETMAP_USE= GITHUB=nodefault