Paths

Table of Contentst

Differential D14361

PyQt: Unconditionally install the .pyi files
ClosedPublic
Actions

Authored by rakuco on Feb 13 2018, 9:05 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 2:20 PM

	Unknown Object (File)
	Fri, Apr 26, 8:04 AM

	Unknown Object (File)
	Thu, Apr 25, 5:25 PM

	Unknown Object (File)
	Wed, Apr 24, 10:41 PM

	Unknown Object (File)
	Wed, Apr 24, 10:41 PM

	Unknown Object (File)
	Wed, Apr 24, 10:41 PM

	Unknown Object (File)
	Wed, Apr 24, 4:22 PM

	Unknown Object (File)
	Mon, Apr 22, 1:26 AM

View All 61 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rP461841: PyQt: Unconditionally install the .pyi files

Summary

r460809 started installing .pyi with the %%PYTHON3%% substituion in the plists. Support for .pyi files was added in Python 3.5, and PyQt's configure.py only installs the files on Python >= 3.5.

This patch removes the version checks from configure.py (the files are just unused in earlier Python versions), as it is easier than checking Python 3's version in each PyQt port's Makefile (or to add the logic to Mk/Uses/pyqt.mk).

See also: bug 225773.

Test Plan

The ports built fine on Poudriere.

Diff Detail

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 15030
Build 15132: arc lint + arc unit

Event Timeline

rakuco created this revision.Feb 13 2018, 9:05 PM

Looks good.

This revision is now accepted and ready to land.Feb 14 2018, 5:28 PM

Closed by commit rP461841: PyQt: Unconditionally install the .pyi files (authored by rakuco). · Explain WhyFeb 14 2018, 9:30 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

comms/

py-qt5-serialport/

2 lines

2 lines

databases/

py-qt5-sql/

2 lines

2 lines

devel/

py-qt5-core/

2 lines

files/

patch-configure.py

37 lines

2 lines

py-qt5-dbus/

2 lines

2 lines

py-qt5-designer/

2 lines

2 lines

py-qt5-help/

2 lines

2 lines

py-qt5-qscintilla2/

2 lines

py-qt5-test/

2 lines

2 lines

graphics/

py-qt5-svg/

2 lines

2 lines

lang/

py-qt5-qml/

2 lines

2 lines

multimedia/

py-qt5-multimedia/

2 lines

2 lines

py-qt5-multimediawidgets/

2 lines

2 lines

net/

py-qt5-network/

2 lines

2 lines

print/

py-qt5-printsupport/

2 lines

2 lines

textproc/

py-qt5-xml/

2 lines

2 lines

py-qt5-xmlpatterns/

2 lines

2 lines

www/

py-qt5-webkit/

2 lines

2 lines

py-qt5-webkitwidgets/

2 lines

2 lines

x11-toolkits/

py-qt5-gui/

2 lines

2 lines

py-qt5-quick/

2 lines

2 lines

py-qt5-widgets/

2 lines

2 lines

x11/

py-qt5-opengl/

2 lines

2 lines

Diff 39281

comms/py-qt5-serialport/Makefile

Loading...

comms/py-qt5-serialport/pkg-plist

Loading...

databases/py-qt5-sql/Makefile

Loading...

databases/py-qt5-sql/pkg-plist

Loading...

devel/py-qt5-core/Makefile

Loading...

devel/py-qt5-core/files/patch-configure.py

Loading...

devel/py-qt5-core/pkg-plist

Loading...

devel/py-qt5-dbus/Makefile

Loading...

devel/py-qt5-dbus/pkg-plist

Loading...

devel/py-qt5-designer/Makefile

Loading...

devel/py-qt5-designer/pkg-plist

Loading...

devel/py-qt5-help/Makefile

Loading...

devel/py-qt5-help/pkg-plist

Loading...

devel/py-qt5-qscintilla2/Makefile

Loading...

devel/py-qt5-test/Makefile

Loading...

devel/py-qt5-test/pkg-plist

Loading...

graphics/py-qt5-svg/Makefile

Loading...

graphics/py-qt5-svg/pkg-plist

Loading...

lang/py-qt5-qml/Makefile

Loading...

lang/py-qt5-qml/pkg-plist

Loading...

multimedia/py-qt5-multimedia/Makefile

Loading...

multimedia/py-qt5-multimedia/pkg-plist

Loading...

multimedia/py-qt5-multimediawidgets/Makefile

Loading...

multimedia/py-qt5-multimediawidgets/pkg-plist

Loading...

net/py-qt5-network/Makefile

Loading...

net/py-qt5-network/pkg-plist

Loading...

print/py-qt5-printsupport/Makefile

Loading...

print/py-qt5-printsupport/pkg-plist

Loading...

textproc/py-qt5-xml/Makefile

Loading...

textproc/py-qt5-xml/pkg-plist

Loading...

textproc/py-qt5-xmlpatterns/Makefile

Loading...

textproc/py-qt5-xmlpatterns/pkg-plist

Loading...

www/py-qt5-webkit/Makefile

Loading...

www/py-qt5-webkit/pkg-plist

Loading...

www/py-qt5-webkitwidgets/Makefile

Loading...

www/py-qt5-webkitwidgets/pkg-plist

Loading...

x11-toolkits/py-qt5-gui/Makefile

Loading...

x11-toolkits/py-qt5-gui/pkg-plist

Loading...

x11-toolkits/py-qt5-quick/Makefile

Loading...

x11-toolkits/py-qt5-quick/pkg-plist

Loading...

x11-toolkits/py-qt5-widgets/Makefile

Loading...

x11-toolkits/py-qt5-widgets/pkg-plist

Loading...

x11/py-qt5-opengl/Makefile

Loading...

x11/py-qt5-opengl/pkg-plist

Loading...