Page MenuHomeFreeBSD

PyQt: Unconditionally install the .pyi files
ClosedPublic

Authored by rakuco on Feb 13 2018, 9:05 PM.

Details

Summary

r460809 started installing .pyi with the %%PYTHON3%% substituion in the plists. Support for .pyi files was added in Python 3.5, and PyQt's configure.py only installs the files on Python >= 3.5.

This patch removes the version checks from configure.py (the files are just unused in earlier Python versions), as it is easier than checking Python 3's version in each PyQt port's Makefile (or to add the logic to Mk/Uses/pyqt.mk).

See also: bug 225773.

Test Plan

The ports built fine on Poudriere.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rakuco created this revision.Feb 13 2018, 9:05 PM
tcberner accepted this revision.Feb 14 2018, 5:28 PM
tcberner added a subscriber: tcberner.

Looks good.

This revision is now accepted and ready to land.Feb 14 2018, 5:28 PM
This revision was automatically updated to reflect the committed changes.