Page MenuHomeFreeBSD

PyQt: Unconditionally install the .pyi files
ClosedPublic

Authored by rakuco on Feb 13 2018, 9:05 PM.
Tags
None
Referenced Files
F132024604: D14361.id39321.diff
Mon, Oct 13, 1:18 AM
Unknown Object (File)
Thu, Oct 9, 4:58 PM
Unknown Object (File)
Thu, Oct 9, 6:32 AM
Unknown Object (File)
Thu, Oct 2, 3:04 PM
Unknown Object (File)
Tue, Sep 30, 2:24 AM
Unknown Object (File)
Mon, Sep 29, 6:13 PM
Unknown Object (File)
Mon, Sep 29, 6:11 PM
Unknown Object (File)
Mon, Sep 29, 6:11 PM
Subscribers

Details

Summary

r460809 started installing .pyi with the %%PYTHON3%% substituion in the plists. Support for .pyi files was added in Python 3.5, and PyQt's configure.py only installs the files on Python >= 3.5.

This patch removes the version checks from configure.py (the files are just unused in earlier Python versions), as it is easier than checking Python 3's version in each PyQt port's Makefile (or to add the logic to Mk/Uses/pyqt.mk).

See also: bug 225773.

Test Plan

The ports built fine on Poudriere.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Feb 14 2018, 5:28 PM
This revision was automatically updated to reflect the committed changes.