efi: Only scan the BLKIO MEDIA once
ClosedPublic

Authored by manu on Mon, Feb 12, 7:29 PM.

Details

Summary

Scan only the BLOCK IO MEDIA once instead of each time for each type of
device (fd, cd and hdd).
Leave the mechanism to free and reprobe all devices if one day we want
to implement a "dev rescan" thing.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
manu created this revision.Mon, Feb 12, 7:29 PM
manu added a reviewer: tsoome.Mon, Feb 12, 7:48 PM
imp accepted this revision.Mon, Feb 12, 7:52 PM

This looks good to my eye

This revision is now accepted and ready to land.Mon, Feb 12, 7:52 PM
tsoome added inline comments.Mon, Feb 12, 8:29 PM
stand/efi/loader/main.c
462 ↗(On Diff #39216)

To be honest, if we fail here, we probably should just error out. Would also be much nicer construct than you currently have.

manu added inline comments.Mon, Feb 12, 8:48 PM
stand/efi/loader/main.c
462 ↗(On Diff #39216)

I really don't like the current design of loader.efi where we return if any EFI error is get, having the standalone efi shell is useful sometimes.

imp added inline comments.Mon, Feb 12, 9:48 PM
stand/efi/loader/main.c
462 ↗(On Diff #39216)

That's the design we're going with.

However, I added an 'out loop' that will drop down to a prompt if you hit a key I thought when we have an error... Or was that just a local hack... I can't recall...

tsoome accepted this revision.Tue, Feb 13, 6:36 AM

shoot:)

This revision was automatically updated to reflect the committed changes.