Page MenuHomeFreeBSD

Link lib/libc/c063 tests to the build.
ClosedPublic

Authored by jilles on Jan 2 2015, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 15, 9:48 PM
Unknown Object (File)
Thu, Nov 14, 8:34 AM
Unknown Object (File)
Wed, Nov 13, 7:59 PM
Unknown Object (File)
Wed, Nov 13, 2:16 PM
Unknown Object (File)
Wed, Nov 13, 11:01 AM
Unknown Object (File)
Sun, Nov 10, 7:57 AM
Unknown Object (File)
Sun, Nov 10, 6:54 AM
Unknown Object (File)
Sun, Nov 10, 2:23 AM
Subscribers
None

Details

Summary

Some files lack required #include <sys/stat.h>.

The faccessat test fails because it tries to use AT_SYMLINK_NOFOLLOW with
faccessat(), which is not specified by POSIX.1-2008.

Test Plan

buildworld and installworld, kyua test in /usr/tests/lib/libc/c063.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jilles retitled this revision from to Link lib/libc/c063 tests to the build..
jilles updated this object.
jilles edited the test plan for this revision. (Show Details)
jilles added reviewers: ngie, jmmv.

Thanks! Forgot to complete this..

contrib/netbsd-tests/lib/libc/c063/t_fchmodat.c
43 ↗(On Diff #2950)

Please put these if #ifdef FreeBSD #endif blocks so I don't forget to upstream them to NetBSD..

"The faccessat test fails because it tries to use AT_SYMLINK_NOFOLLOW with
faccessat(), which is not specified by POSIX.1-2008."

The testcase should either be #ifdef NetBSD'ed out, or have a block like this added to it:

#ifdef __FreeBSD__
atf_tc_expect_fail("Depends on non-standard behavior not mentioned in POSIX.1-2008");
#endif
jilles edited edge metadata.

Apply changes requested by ngie. 'kyua test' in c063/ is happy now.

ngie edited edge metadata.
This revision is now accepted and ready to land.Jan 2 2015, 10:43 PM
jilles updated this revision to Diff 2965.

Closed by commit rS276590 (authored by @jilles).