The blocks were updated to conform to the 'Order of Variables in Port
Makefiles' chapter in the Porter's Handbook.
Details
- Reviewers
vvd - Commits
- rP460151: www/tomcat85: Silence portlint warnings and modernize
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
pkg-plist is ok.
Makefile: variables OPTIONS_DEFAULT= and HOST_MANAGER_DESC= are too long - both blocks look with ledges:
OPTIONS_DEFINE= HOST_MANAGER MANAGER DOCS EXAMPLES ROOT
OPTIONS_DEFAULT= HOST_MANAGER MANAGER DOCS EXAMPLES ROOT
OPTIONS_SUB= yes
DOCS_DESC= Install Documentation web application
EXAMPLES_DESC= Install Examples web application
HOST_MANAGER_DESC= Install Host Manager application
MANAGER_DESC= Install Manager web application
ROOT_DESC= Install default ROOT web application
IMHO, this is look better:
OPTIONS_DEFINE= HOST_MANAGER MANAGER DOCS EXAMPLES ROOT
OPTIONS_DEFAULT= HOST_MANAGER MANAGER DOCS EXAMPLES ROOT
OPTIONS_SUB= yes
DOCS_DESC= Install Documentation web application
EXAMPLES_DESC= Install Examples web application
HOST_MANAGER_DESC= Install Host Manager application
MANAGER_DESC= Install Manager web application
ROOT_DESC= Install default ROOT web application
What do you think?