Page MenuHomeFreeBSD

www/tomcat85: Silence portlint warnings and modernize
ClosedPublic

Authored by jrm on Jan 27 2018, 1:19 PM.
Tags
None
Referenced Files
F82163750: D14071.id38526.diff
Fri, Apr 26, 2:32 AM
F82163749: D14071.id38555.diff
Fri, Apr 26, 2:32 AM
F82163500: D14071.id38530.diff
Fri, Apr 26, 2:28 AM
F82163237: D14071.id.diff
Fri, Apr 26, 2:25 AM
F82163192: D14071.id38553.diff
Fri, Apr 26, 2:25 AM
F82136536: D14071.diff
Thu, Apr 25, 8:27 PM
Unknown Object (File)
Wed, Apr 3, 2:20 PM
Unknown Object (File)
Wed, Apr 3, 2:19 PM
Subscribers
None

Details

Summary

The blocks were updated to conform to the 'Order of Variables in Port
Makefiles' chapter in the Porter's Handbook.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • more Re-ordering that was missed the first time

pkg-plist is ok.

Makefile: variables OPTIONS_DEFAULT= and HOST_MANAGER_DESC= are too long - both blocks look with ledges:
OPTIONS_DEFINE= HOST_MANAGER MANAGER DOCS EXAMPLES ROOT
OPTIONS_DEFAULT= HOST_MANAGER MANAGER DOCS EXAMPLES ROOT
OPTIONS_SUB= yes

DOCS_DESC= Install Documentation web application
EXAMPLES_DESC= Install Examples web application
HOST_MANAGER_DESC= Install Host Manager application
MANAGER_DESC= Install Manager web application
ROOT_DESC= Install default ROOT web application

IMHO, this is look better:
OPTIONS_DEFINE= HOST_MANAGER MANAGER DOCS EXAMPLES ROOT
OPTIONS_DEFAULT= HOST_MANAGER MANAGER DOCS EXAMPLES ROOT
OPTIONS_SUB= yes

DOCS_DESC= Install Documentation web application
EXAMPLES_DESC= Install Examples web application
HOST_MANAGER_DESC= Install Host Manager application
MANAGER_DESC= Install Manager web application
ROOT_DESC= Install default ROOT web application

What do you think?

  • align values in blocks as requested

Have to do same with www/tomcat9.

This revision is now accepted and ready to land.Jan 28 2018, 12:40 AM
This revision was automatically updated to reflect the committed changes.