Differential D1403
net/p5-Net-Amazon-EC2: Update version 0.24=>0.29 Authored by bofh on Dec 31 2014, 8:54 AM. Tags None Referenced Files
Subscribers
Details Fix broken TEST_DEPENDS. TEST_DEPENDS has been fixed as per below information from mat. Differential Revision: https://reviews.freebsd.org/D1403
Diff Detail
Event TimelineComment Actions You've removed some dependencies that had something to do with testing. This is the kind of thing that might get mentioned in the summary. For example, explain why these dependencies are no longer needed, were they there in error before, etc. Explaining stuff like that in the commit message makes it clear that you removed those intentionally (not accidentally) and also explains "why". I'll accept the revision, but you should consider if the commit message needs beefing up. Comment Actions Fix broken TEST_DEPENDS. TEST_DEPENDS has been fixed as per below information from mat. Comment Actions The revision is fine, but the summary is too much information. You can just note that p5-Test-Exception is used for testing only, so it's been changed to a conditional depends -- and that it was this way before. You don't need to quote mat like that or call out his name in a commit message. Comment Actions I don't mind being quoted, but I don't need to be, it is the policy of perl@ to put test dependencies in TEST_DEPENDS, cf https://wiki.freebsd.org/Perl, regardless of what the build system used by the port says. One day, someone will write a test target in bsd.port.mk and TEST_DEPENDS will become a real thing. Until then, we put dependencies that are not needed for anything else than testing in there. Comment Actions And adding on that, if you don't know how to deal with perl modules as ports, either don't, or ask for a review from the Perl team. Comment Actions Thanks Mat for the detailed information about the TEST_DEPENDS. And in future if I am unsure about PERL framework will add perl@ for a review. |