Page MenuHomeFreeBSD

net/p5-Net-Amazon-EC2: Update version 0.24=>0.29
ClosedPublic

Authored by bofh on Dec 31 2014, 8:54 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 6, 1:56 AM
Unknown Object (File)
Wed, Mar 6, 1:56 AM
Unknown Object (File)
Wed, Mar 6, 1:55 AM
Unknown Object (File)
Tue, Mar 5, 4:10 AM
Unknown Object (File)
Jan 10 2024, 1:30 AM
Unknown Object (File)
Dec 29 2023, 5:44 PM
Unknown Object (File)
Dec 29 2023, 5:44 PM
Unknown Object (File)
Dec 29 2023, 5:40 PM
Subscribers

Details

Reviewers
bapt
marino
Summary

Fix broken TEST_DEPENDS. TEST_DEPENDS has been fixed as per below information from mat.
"Unless what was in TEST_DEPENDS is used for anything else that testing the module (aka in the "t" directory) it must stay as TEST_DEPENDS, and not be added to BUILD_DEPENDS."

Differential Revision: https://reviews.freebsd.org/D1403
Submitted by: mat
Approved by: xxxx(mentor)

Test Plan

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

bofh retitled this revision from to net/p5-Net-Amazon-EC2: Update version 0.24=>0.29.
bofh updated this object.
bofh edited the test plan for this revision. (Show Details)
bofh added reviewers: bapt, marino.
bofh set the repository for this revision to rP FreeBSD ports repository.
bofh updated this object.
marino edited edge metadata.

You've removed some dependencies that had something to do with testing. This is the kind of thing that might get mentioned in the summary. For example, explain why these dependencies are no longer needed, were they there in error before, etc.

Explaining stuff like that in the commit message makes it clear that you removed those intentionally (not accidentally) and also explains "why".

I'll accept the revision, but you should consider if the commit message needs beefing up.

This revision is now accepted and ready to land.Dec 31 2014, 12:31 PM
bofh updated this object.
bofh edited the test plan for this revision. (Show Details)
bofh edited edge metadata.
bofh set the repository for this revision to rP FreeBSD ports repository.
bofh added a subscriber: mat.

Fix broken TEST_DEPENDS. TEST_DEPENDS has been fixed as per below information from mat.

This revision now requires review to proceed.Jan 2 2015, 6:36 PM
marino edited edge metadata.

The revision is fine, but the summary is too much information.

You can just note that p5-Test-Exception is used for testing only, so it's been changed to a conditional depends -- and that it was this way before. You don't need to quote mat like that or call out his name in a commit message.

This revision is now accepted and ready to land.Jan 3 2015, 1:27 PM

I don't mind being quoted, but I don't need to be, it is the policy of perl@ to put test dependencies in TEST_DEPENDS, cf https://wiki.freebsd.org/Perl, regardless of what the build system used by the port says.

One day, someone will write a test target in bsd.port.mk and TEST_DEPENDS will become a real thing. Until then, we put dependencies that are not needed for anything else than testing in there.

And adding on that, if you don't know how to deal with perl modules as ports, either don't, or ask for a review from the Perl team.

Thanks Mat for the detailed information about the TEST_DEPENDS. And in future if I am unsure about PERL framework will add perl@ for a review.