Page MenuHomeFreeBSD
Differential D14017

Remove some apparently unused variables.
ClosedPublic
Actions

Authored by pfg on Jan 22 2018, 5:43 PM.
Tags
None
Referenced Files
F132995855: D14017.id.diff
Tue, Oct 21, 10:15 PM
F132992024: D14017.id38320.diff
Tue, Oct 21, 9:31 PM
F132992022: D14017.id38351.diff
Tue, Oct 21, 9:31 PM
Unknown Object (File)
Tue, Oct 21, 9:55 AM
Unknown Object (File)
Tue, Oct 14, 5:55 AM
Unknown Object (File)
Fri, Sep 26, 4:10 PM
Unknown Object (File)
Wed, Sep 24, 10:40 AM
Unknown Object (File)
Sep 17 2025, 6:43 AM
View All 65 Files
Subscribers
imp

Details

Reviewers
fsu
Commits
rS328280: extfs: Remove unused variables.
Summary

Detected by clang scan-build.

Test Plan

Build the module.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pfg created this revision.Jan 22 2018, 5:43 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 22 2018, 5:43 PM
Harbormaster completed remote builds in B14527: Diff 38320.Jan 22 2018, 5:43 PM
fsu accepted this revision.Jan 23 2018, 7:56 AM

Yep, accepted.
The code of extents part should be slightly cleaned up, it is my "nearest" future plans)
Also, it would be great to little bit rename variables inside the ext2_ei_csum(), but I will do it by myself later to avoid influence to logic.

This revision is now accepted and ready to land.Jan 23 2018, 7:56 AM
Closed by commit rS328280: extfs: Remove unused variables. (authored by pfg). · Explain WhyJan 23 2018, 2:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
fs/
ext2fs/
3 lines
11 lines
3 lines

Diff 38351

View Options

head/sys/fs/ext2fs/ext2_csum.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_extents.c

Loading...
View Options

head/sys/fs/ext2fs/ext2_lookup.c

Loading...