stand/fdt: Fallback to `name` + ".dtbo" if we fail to load `name`
ClosedPublic
Actions

Authored by kevans on Jan 18 2018, 4:08 PM.

Tags

None

Referenced Files

	F166025849: D13968.id38155.diff
	Tue, Aug 11, 4:02 AM

	F166003571: D13968.id38358.diff
	Mon, Aug 10, 10:59 PM

	F165992433: D13968.diff
	Mon, Aug 10, 9:03 PM

	Unknown Object (File)
	Mon, Aug 10, 9:14 AM

	Unknown Object (File)
	Mon, Aug 10, 6:29 AM

	Unknown Object (File)
	Sun, Jul 26, 7:09 PM

	Unknown Object (File)
	Sun, Jul 26, 7:06 PM

	Unknown Object (File)
	Sat, Jul 25, 3:17 PM

View All Files

Subscribers

None

Details

Reviewers

imp
gonzo

Commits

rS328293: stand/fdt: Fallback to `name` + ".dtbo" if we fail to load `name`

Summary

This behavior also matches a Linux-ism by allowing fdt_overlays to specify names of overlays without an extension (e.g. fdt-overlays="sunxi-h3-h5-emac")

If we fail to load the file given by a name in fdt_overlays, try again with ".dtbo" appended to it. This still allows overlays to lack .dtbo extension if user prefers it and just adds a fallback cushion.

Future work could might this from a hard-coded ".dtbo" to loader.conf(5) configuration option.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Jan 18 2018, 4:08 PM

LGTM

This revision is now accepted and ready to land.Jan 18 2018, 7:12 PM

Closed by commit rS328293: stand/fdt: Fallback to `name` + ".dtbo" if we fail to load `name` (authored by kevans). · Explain WhyJan 23 2018, 6:03 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

fdt/

fdt_loader_cmd.c

68 lines

Diff 38358

View Options

head/stand/fdt/fdt_loader_cmd.c

stand/fdt: Fallback to `name` + ".dtbo" if we fail to load `name`ClosedPublicActions