Differential D13968

stand/fdt: Fallback to `name` + ".dtbo" if we fail to load `name`
ClosedPublic
Actions

Authored by kevans on Jan 18 2018, 4:08 PM.

Details

Reviewers
imp
gonzo
Commits
rS328293: stand/fdt: Fallback to `name` + ".dtbo" if we fail to load `name`
Summary

This behavior also matches a Linux-ism by allowing fdt_overlays to specify names of overlays without an extension (e.g. fdt-overlays="sunxi-h3-h5-emac")

If we fail to load the file given by a name in fdt_overlays, try again with ".dtbo" appended to it. This still allows overlays to lack .dtbo extension if user prefers it and just adds a fallback cushion.

Future work could might this from a hard-coded ".dtbo" to loader.conf(5) configuration option.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kevans created this revision.Jan 18 2018, 4:08 PM
gonzo accepted this revision.Jan 18 2018, 7:12 PM

LGTM

This revision is now accepted and ready to land.Jan 18 2018, 7:12 PM
Closed by commit rS328293: stand/fdt: Fallback to `name` + ".dtbo" if we fail to load `name` (authored by kevans, committed by ). · Explain WhyJan 23 2018, 6:03 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mhead/stand/fdt/fdt_loader_cmd.c (68 lines)

Diff 38358

View Options

head/stand/fdt/fdt_loader_cmd.c

Loading...