Page MenuHomeFreeBSD
Differential D1392

Get rid of obsolete -mppc64bridge assembler flag
ClosedPublic
Actions

Authored by dim on Dec 29 2014, 10:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 2 2024, 10:27 AM
Unknown Object (File)
Oct 2 2024, 10:00 AM
Unknown Object (File)
Sep 28 2024, 7:37 AM
Unknown Object (File)
Sep 21 2024, 4:01 PM
Unknown Object (File)
Sep 14 2024, 12:48 AM
Unknown Object (File)
Sep 2 2024, 2:17 AM
Unknown Object (File)
Sep 1 2024, 10:48 PM
Unknown Object (File)
Sep 1 2024, 5:58 AM
View All 58 Files
Subscribers
None

Details

Reviewers
nwhitehorn
jhibbits
Commits
rS276368: For building sys/boot/powerpc, get rid of the obsolete -mppc64bridge
Summary

In r132997, more than 10 years ago, grehan added -Wa,-mppc64bridge to a few Makefiles under sys/boot/powerpc.

Apparently this flag was required with the GNU as version of that time, but it does not seem to be necessary anymore. I tried building sys/boot/powerpc using gcc and gas, both with and without this flag, but the output was exactly identical.

Since clang does not support this flag, can we please dump it entirely?

Test Plan

Compile and compare output.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dim updated this revision to Diff 2910.Dec 29 2014, 10:35 AM
dim retitled this revision from to Get rid of obsolete -mppc64bride assembler flag.
dim updated this object.
dim edited the test plan for this revision. (Show Details)
dim added reviewers: nwhitehorn, jhibbits.
dim retitled this revision from Get rid of obsolete -mppc64bride assembler flag to Get rid of obsolete -mppc64bridge assembler flag.Dec 29 2014, 10:35 AM
nwhitehorn accepted this revision.Dec 29 2014, 2:20 PM
nwhitehorn edited edge metadata.

Nuke it. I don't think it was necessary even when it was added. Thanks!

This revision is now accepted and ready to land.Dec 29 2014, 2:20 PM
dim closed this revision.Dec 29 2014, 5:36 PM
dim updated this revision to Diff 2914.

Closed by commit rS276368 (authored by @dim).

Revision Contents
Changeset List

PathSize
projects/
clang350-import/
sys/
boot/
powerpc/
ofw/
3 lines
ps3/
3 lines

Diff 2914

View Options

projects/clang350-import/sys/boot/powerpc/ofw/Makefile

Loading...
View Options

projects/clang350-import/sys/boot/powerpc/ps3/Makefile

Loading...