Page MenuHomeFreeBSD

Use XPT_GET_ADVINFO for retrieving MMC params
ClosedPublic

Authored by scottl on Jan 11 2018, 6:07 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 10, 2:44 PM
Unknown Object (File)
Mon, Oct 6, 1:14 AM
Unknown Object (File)
Wed, Oct 1, 4:32 PM
Unknown Object (File)
Sat, Sep 20, 12:42 AM
Unknown Object (File)
Sat, Sep 20, 12:37 AM
Unknown Object (File)
Sat, Sep 20, 12:29 AM
Unknown Object (File)
Sat, Sep 20, 12:29 AM
Unknown Object (File)
Sat, Sep 20, 12:25 AM
Subscribers
None

Details

Summary

Fix the accidental ABI breakage for CCBs and use the ADVINFO CCB
for retrieving the mmc_params structure.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This looks good to me, modulo my one question...
I'll test it out shortly.

sys/cam/mmc/mmc_xpt.c
373 โ†—(On Diff #37822)

I assume the ioctl takes care of setting up the kernel buffer for this, then copying it out to user space?

sys/cam/mmc/mmc_xpt.c
373 โ†—(On Diff #37822)

I believe it's handled automatically in cam_periph_mapmem()

This change LGTM, I would like to know how this was discovered?

This revision is now accepted and ready to land.Jan 19 2018, 2:23 PM

I came across it during some other clean-up work.