Page MenuHomeFreeBSD

Use XPT_GET_ADVINFO for retrieving MMC params
ClosedPublic

Authored by scottl on Jan 11 2018, 6:07 PM.

Details

Summary

Fix the accidental ABI breakage for CCBs and use the ADVINFO CCB
for retrieving the mmc_params structure.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

scottl created this revision.Jan 11 2018, 6:07 PM
imp added a comment.Jan 11 2018, 6:23 PM

This looks good to me, modulo my one question...
I'll test it out shortly.

sys/cam/mmc/mmc_xpt.c
373 ↗(On Diff #37822)

I assume the ioctl takes care of setting up the kernel buffer for this, then copying it out to user space?

scottl added inline comments.Jan 11 2018, 6:32 PM
sys/cam/mmc/mmc_xpt.c
373 ↗(On Diff #37822)

I believe it's handled automatically in cam_periph_mapmem()

kibab accepted this revision.Jan 19 2018, 2:23 PM

This change LGTM, I would like to know how this was discovered?

This revision is now accepted and ready to land.Jan 19 2018, 2:23 PM

I came across it during some other clean-up work.