Differential D13839

Fix minor locking issues in the PowerMac Uninorth PCI driver
ClosedPublic
Actions

Authored by landonf on Jan 10 2018, 9:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 28, 4:44 AM

	Unknown Object (File)
	Mon, May 26, 12:26 PM

	Unknown Object (File)
	Tue, May 20, 7:27 PM

	Unknown Object (File)
	Mon, May 12, 2:24 PM

	Unknown Object (File)
	Sun, May 11, 2:28 PM

	Unknown Object (File)
	Sun, May 4, 3:18 PM

	Unknown Object (File)
	Sun, May 4, 9:20 AM

	Unknown Object (File)
	Apr 30 2025, 2:24 AM

View All 83 Files

Subscribers

Details

Reviewers

Commits

rS327798: Fix minor locking issues in the Power Mac Uninorth PCI bridge driver.

Summary

Call resource_int_value() once during attach, rather than within the pci_(read|write)_config() code path; this avoids taking a blocking mutex to read kenv variables.
Use a spin lock to protect non-atomic config space accesses (this matches the behavior of the Darwin AppleMacRiscPCI driver).

Test Plan

Tested for regressions on a PowerBook5,8.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

landonf created this revision.Jan 10 2018, 9:26 PM

Harbormaster completed remote builds in B14269: Diff 37757.Jan 10 2018, 9:26 PM

Add mtx_assert(MA_OWNED) to uninorth_enable_config() for good measure.

Harbormaster completed remote builds in B14272: Diff 37760.Jan 10 2018, 9:37 PM

jhibbits accepted this revision.Jan 10 2018, 9:41 PM

jhibbits added inline comments.

sys/powerpc/powermac/uninorthvar.h
43 ↗	(On Diff #37760)	Match whitespace? Might be phabricator messing with it, but just double check.

This revision is now accepted and ready to land.Jan 10 2018, 9:41 PM

landonf marked an inline comment as done.Jan 10 2018, 9:42 PM

landonf added inline comments.

sys/powerpc/powermac/uninorthvar.h
43 ↗	(On Diff #37760)	Yeah, looks like phabricator behaving badly.

Closed by commit rS327798: Fix minor locking issues in the Power Mac Uninorth PCI bridge driver. (authored by landonf). · Explain WhyJan 10 2018, 10:19 PM

This revision was automatically updated to reflect the committed changes.

landonf marked an inline comment as done.

Herald added a subscriber: imp. · View Herald TranscriptJan 10 2018, 10:19 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

powermac/

35 lines

2 lines

Diff 37762

head/sys/powerpc/powermac/uninorthpci.c

Loading...

head/sys/powerpc/powermac/uninorthvar.h

Loading...