net/asio: Added NO_ARCH=yes; Removed USES=gmake; Regenerated patches; Sorted the USES section
ClosedPublic
Actions

Authored by yuri on Jan 9 2018, 6:15 AM.

Details

Reviewers

tcberner
adamw

Commits

rP460459: net/asio: Added NO_ARCH=yes; Removed USES=gmake; Regenerated patches; Sorted…

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224578

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Jan 9 2018, 6:15 AM

Herald added a subscriber: mat. · View Herald TranscriptJan 9 2018, 6:15 AM

tcberner added inline comments.Jan 9 2018, 6:22 AM

net/asio/files/patch-configure
1 ↗	(On Diff #37664)	you can revert this change, it only changes the metadata not the function of the patch, right?

Harbormaster completed remote builds in B14209: Diff 37665.Jan 9 2018, 6:27 AM

yuri added inline comments.Jan 9 2018, 6:27 AM

net/asio/files/patch-configure
1 ↗	(On Diff #37664)	Yes.

tcberner added inline comments.Jan 9 2018, 8:27 PM

net/asio/files/patch-include_asio_ssl_impl_context.ipp
8 ↗	(On Diff #37665)	^ maybe I'm missing the context, but whats the point of the change?

net/asio/files/patch-include_asio_ssl_impl_context.ipp
8 ↗	(On Diff #37665)	`make makepatch` regenerates them this way. portlint complained about `patch-configure`. I think, they should be left in a state left by `make makepatch`, even though the changes look meaningless (actually, there is no real change).

yuri marked 2 inline comments as done.Jan 10 2018, 8:09 AM

@tcberner

You've asked what was the point of patch changes.
portlint complained that patches aren't in a standard form, and they were regenerated. This is the only point. The change is a noop otherwise.

mat added inline comments.Jan 29 2018, 11:40 AM

net/asio/files/patch-configure
1 ↗	(On Diff #37664)	It does not, it also changes the number context lines, from a non default 2 to 3, and it is always nice to be consistent across the board.