Paths

Table of Contentst

Differential D13764

graphics/py-pyembree: Update to 0.1.2; Unbroke it, it was breaking in configure.
ClosedPublic
Actions

Authored by yuri on Jan 4 2018, 11:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 13, 10:55 PM

	Unknown Object (File)
	Fri, Nov 1, 2:30 AM

	Unknown Object (File)
	Thu, Oct 31, 6:44 AM

	Unknown Object (File)
	Thu, Oct 31, 3:07 AM

	Unknown Object (File)
	Fri, Oct 25, 6:03 AM

	Unknown Object (File)
	Oct 14 2024, 6:28 PM

	Unknown Object (File)
	Sep 24 2024, 4:35 PM

	Unknown Object (File)
	Sep 20 2024, 7:56 AM

View All 71 Files

Subscribers

Details

Reviewers

tcberner
adamw

Commits

rP458510: graphics/py-pyembree: Update to 0.1.2; Unbroke it, it was breaking in configure

Summary

Simple update.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Jan 4 2018, 11:53 AM

Herald added a subscriber: mat. · View Herald TranscriptJan 4 2018, 11:53 AM

tcberner added inline comments.Jan 8 2018, 6:34 PM

graphics/py-pyembree/Makefile
20 ↗	(On Diff #37506)	^ why this change?

.

Harbormaster completed remote builds in B14194: Diff 37643.Jan 8 2018, 7:03 PM

tcberner added inline comments.Jan 8 2018, 7:14 PM

graphics/py-pyembree/Makefile
20 ↗	(On Diff #37506)	why do you keep marking stuff done, without either commenting on it changing it

yuri marked an inline comment as done.Jan 8 2018, 7:20 PM

yuri added inline comments.

graphics/py-pyembree/Makefile
20 ↗	(On Diff #37506)	Ordered them in the order of use. `distutils` is used first. Actually, I want to change it to `USE_PYTHON=distutils cython autoplist` Following this logic, it should also be `USES=python localbase`, but I've heard people saying that `USES` should be strictly sorted, so it is as it is.
20 ↗	(On Diff #37506)	But I did update the `USE_PYTHON` line though.

tcberner added inline comments.Jan 8 2018, 7:21 PM

graphics/py-pyembree/Makefile
20 ↗	(On Diff #37506)	it still changes it, without an explanation "why"

yuri marked 3 inline comments as done.Jan 8 2018, 7:24 PM

yuri added inline comments.

graphics/py-pyembree/Makefile
20 ↗	(On Diff #37506)	I wrote an explanation "why" :-) Please see a few comments up: `Ordered them in the order of use` Or, perhaps, the phabricator shows you a different set of comments?

tcberner added inline comments.Jan 8 2018, 7:25 PM

graphics/py-pyembree/Makefile
20 ↗	(On Diff #37506)	Yes, after the fact :) But I don't see any benefit of the change. I would change it if its broken otherwise alphabetizes this just seems like additional noise to me :)

yuri marked 3 inline comments as done.Jan 8 2018, 7:32 PM

yuri added inline comments.

graphics/py-pyembree/Makefile
20 ↗	(On Diff #37506)	Yes, after the fact :) Actually, I pressed the button on the explanation first, I think. :) this just seems like additional noise to me :) Ok, changed this back.

.

yuri marked 2 inline comments as done.Jan 8 2018, 10:35 PM

tcberner accepted this revision.Jan 9 2018, 5:36 AM

This revision is now accepted and ready to land.Jan 9 2018, 5:36 AM

Closed by commit rP458510: graphics/py-pyembree: Update to 0.1.2; Unbroke it, it was breaking in configure (authored by yuri). · Explain WhyJan 9 2018, 6:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

graphics/

py-pyembree/

11 lines

6 lines

Diff 37663

head/graphics/py-pyembree/Makefile

Loading...

head/graphics/py-pyembree/distinfo

Loading...