devel/gogs: rc.d script status does not work correctly; history pagination fix submitted to the upstream as a PR
AbandonedPublic

Authored by yuri on Dec 31 2017, 7:05 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14061
Build 14245: arc lint + arc unit
yuri created this revision.Dec 31 2017, 7:05 AM
yuri added a comment.Dec 31 2017, 7:06 AM

Maintainer patch.

yuri retitled this revision from devel/gogs: rc.d script status does not work correctly to devel/gogs: rc.d script status does not work correctly; history pagination fix submitted to upstream as a PR.Dec 31 2017, 4:54 PM
yuri retitled this revision from devel/gogs: rc.d script status does not work correctly; history pagination fix submitted to upstream as a PR to devel/gogs: rc.d script status does not work correctly; history pagination fix submitted to the upstream as a PR.
tcberner added inline comments.Jan 1 2018, 11:28 AM
devel/gogs/files/patch-routes_repo_commit.go
2

^ I would add the url to the upstream commit/pull request at the top of the file.

yuri updated this revision to Diff 37355.Jan 1 2018, 5:15 PM

Added URL of the pull request.

tcberner added inline comments.Jan 2 2018, 9:54 AM
devel/gogs/files/patch-routes_repo_commit.go
8

^ not as comment, but at the top of the patch -- people don't want to read the patch to know what it does :)

 upstream PR: https://github.com/gogits/gogs/pull/4965


--- routes/repo/commit.go.orig        2017-12-31 13:07:52 UTC
+++ routes/repo/commit.go
[...]

this way it instantly visiable wihtout having to know where to look :)

yuri marked 2 inline comments as done.Jan 2 2018, 9:58 AM
yuri abandoned this revision.Jan 8 2018, 10:13 PM

Transferred to pi@.