New port: misc/lxi-tools: Collection of tools that enables control of LXI compatible instruments
AbandonedPublic
Actions

Authored by yuri on Dec 30 2017, 12:03 AM.

Details

Reviewers

tcberner
adamw

Summary

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 13952
Build 14147: arc lint + arc unit

misc/lxi-tools/Makefile
19	Not needed.
29	Any reason not to enable BASH by default ?

yuri marked 2 inline comments as done.Dec 30 2017, 8:44 AM

yuri added inline comments.

misc/lxi-tools/Makefile
29	For consistency with other shells (in other ports) and with bash in other ports. And this is real cheap. :-)

misc/lxi-tools/Makefile
29	Consistency is a nice thing, but in this case, most of those ports are wrong, and not installing a 500 bytes file because someone may not needed is not how default options are supposed to work.

yuri marked 3 inline comments as done.Dec 30 2017, 9:22 AM

yuri added inline comments.

misc/lxi-tools/Makefile
29	Adam Weinberger also expressed preference to allow user decide such things, no matter how small. I measured the overhead on another port, and it was really small.

misc/lxi-tools/Makefile
29	I never said to remove the option. Advanced users using the ports tree or building their own packages can decide what they want. I said that some users will need the completion file, and this is reason enough to enable the option by default. With this the way it now is, someone installing the package who needs the completion will have to install the ports tree, learn how to build the ports, and then cry with pain each time this port is updated because `pkg upgrade` will install the version without the completion. They will have to remember to upgrade their ports tree, remember how to reinstall the port with the completion.

yuri marked 3 inline comments as done.Dec 30 2017, 9:34 AM

yuri added inline comments.

misc/lxi-tools/Makefile
29	Shouldn't such things be enabled on the framework level? Just like `DOCS` is enabled by default, you can make `BASH` enabled by default too, and remove `OPTIONS_DEFAULT=BASH` from all ports.

dmgk added inline comments.

misc/lxi-tools/Makefile
29	Hi Mat, BASH option default here was based on merit. This software has small command/options set and doesn't need any completions (IMO). This particular bash completion doesn't do much, I included it in the port only because it is in the upstream package.

misc/lxi-tools/Makefile
29	Not for shell completion files, I haven't. Ports should ALWAYS install their shell completion files. You change shells, enable completions, and suddenly all the ports you've installed have completions. Don't make it an option. Always install it. It simply makes for a much better user experience.

yuri marked an inline comment as done.Dec 30 2017, 6:18 PM

yuri added inline comments.

misc/lxi-tools/Makefile
29	Ports should ALWAYS install their shell completion files. Then, IMO, they should all be made default in the framework. -) They should be removed from `OPTIONS_DEFAULT` in individual ports, and set as a default globally. Users will still be able to disable them in `/etc/make.conf`.