Page MenuHomeFreeBSD

Mk/Uses/perl5.mk : unregister perl 5.14
ClosedPublic

Authored by rene on Dec 24 2014, 11:13 PM.
Tags
None
Referenced Files
F106020783: D1368.diff
Tue, Dec 24, 12:58 AM
Unknown Object (File)
Wed, Dec 4, 10:25 AM
Unknown Object (File)
Sat, Nov 30, 10:05 AM
Unknown Object (File)
Oct 12 2024, 3:27 PM
Unknown Object (File)
Oct 10 2024, 6:47 PM
Unknown Object (File)
Oct 6 2024, 1:49 PM
Unknown Object (File)
Sep 18 2024, 1:13 PM
Unknown Object (File)
Sep 16 2024, 3:15 AM
Subscribers

Details

Reviewers
sunpoet
mat
Group Reviewers
Perl
Summary

lang/perl5.14 will expire on 2014-12-31. When deleting this port, it must also be unregistered from Mk/Uses/perl5.mk (or at least the default for PERL_LEVEL must be set to perl 5.16)

Test Plan

Mk/bsd.default-versions.mk sets the default Perl port to lang/perl5.18 , but an exp-run might be sensible to catch ports that still depend on lang/perl5.14 (there should be none).

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rene retitled this revision from to Mk/Uses/perl5.mk : unregister perl 5.14.
rene updated this object.
rene edited the test plan for this revision. (Show Details)
rene added a reviewer: Perl.
rene set the repository for this revision to rP FreeBSD ports repository.
mat added a reviewer: mat.
mat added a subscriber: mat.

other than the small changes mentionned...

Macro shipit:

:-)

Mk/Uses/perl5.mk
16–17

There is no real need to change this, it is an example after all, not the current value :-)

23

I think this should be changed to (for example: perl5.18) so that it does not need to be updated any more.

This revision is now accepted and ready to land.Dec 25 2014, 12:23 AM

I applied the comments to my local version.

In D1368#9, @rene wrote:

I applied the comments to my local version.

You know, you can use arc diff --update DXXXX [path/files...] to update the review :-)

sunpoet added a reviewer: sunpoet.
sunpoet added a subscriber: sunpoet.

Looks good to me.

Mk/Uses/perl5.mk
16–17

It's no harm to use an up-to-date example (instead of an outdated one).

Mk/Uses/perl5.mk
16–17

Yes, but it is an *example* not the current value, it does no harm at all to not keep it currrent, people who are reading this file are the people hacking on it, and they are supposed to have a clue. Everybody else must be directed to read the porter's handbook.