nandtool: Add missing mode for open() with O_CREAT
ClosedPublic
Actions

Authored by jilles on Dec 24 2017, 3:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 2, 3:05 PM

	Unknown Object (File)
	Thu, May 2, 3:05 PM

	Unknown Object (File)
	Thu, May 2, 2:34 PM

	Unknown Object (File)
	Thu, May 2, 12:20 PM

	Unknown Object (File)
	Jan 22 2024, 7:53 AM

	Unknown Object (File)
	Dec 20 2023, 4:56 AM

	Unknown Object (File)
	Dec 8 2023, 4:40 PM

	Unknown Object (File)
	Dec 8 2023, 3:36 PM

View All 23 Files

Subscribers

imp

Details

Reviewers

imp

Commits

rS327211: nandtool: Add missing mode for open() with O_CREAT

Summary

If O_CREAT is given, open() needs a mode argument.
Follow the umask by passing 0666.

Test Plan

buildworld and installworld only

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 13769
Build 13983: arc lint + arc unit

Event Timeline

jilles created this revision.Dec 24 2017, 3:09 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 24 2017, 3:09 PM

Harbormaster completed remote builds in B13769: Diff 36966.Dec 24 2017, 3:09 PM

imp accepted this revision.Dec 24 2017, 4:41 PM

This revision is now accepted and ready to land.Dec 24 2017, 4:41 PM

Closed by commit rS327211: nandtool: Add missing mode for open() with O_CREAT (authored by jilles). · Explain WhyDec 26 2017, 4:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

usr.sbin/

nandtool/

nand_read.c

2 lines

nand_readoob.c

2 lines

Diff 36966

View Options

usr.sbin/nandtool/nand_read.c