nandtool: Add missing mode for open() with O_CREAT
ClosedPublic
Actions

Authored by jilles on Dec 24 2017, 3:09 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Sep 25, 5:46 PM

	Unknown Object (File)
	Sun, Sep 13, 7:03 PM

	Unknown Object (File)
	Sun, Sep 13, 6:54 PM

	Unknown Object (File)
	Aug 18 2026, 3:56 PM

	Unknown Object (File)
	Aug 17 2026, 8:42 PM

	Unknown Object (File)
	Aug 16 2026, 7:35 PM

	Unknown Object (File)
	Aug 14 2026, 6:45 PM

	Unknown Object (File)
	Aug 14 2026, 3:03 PM

View All Files

Subscribers

imp

Details

Reviewers

imp

Commits

rS327211: nandtool: Add missing mode for open() with O_CREAT

Summary

If O_CREAT is given, open() needs a mode argument.
Follow the umask by passing 0666.

Test Plan

buildworld and installworld only

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jilles created this revision.Dec 24 2017, 3:09 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 24 2017, 3:09 PM

Harbormaster completed remote builds in B13769: Diff 36966.Dec 24 2017, 3:09 PM

imp accepted this revision.Dec 24 2017, 4:41 PM

This revision is now accepted and ready to land.Dec 24 2017, 4:41 PM

Closed by commit rS327211: nandtool: Add missing mode for open() with O_CREAT (authored by jilles). · Explain WhyDec 26 2017, 4:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

nandtool/

nand_read.c

2 lines

nand_readoob.c

2 lines

Diff 37053

View Options

head/usr.sbin/nandtool/nand_read.c