Page MenuHomeFreeBSD
Differential D13402

Don't free() uninitialized memory
ClosedPublic
Actions

Authored by markj on Dec 7 2017, 12:01 AM.
Tags
None
Referenced Files
F162039634: D13402.id36339.diff
Thu, Jul 9, 4:02 AM
Unknown Object (File)
Fri, Jul 3, 6:41 PM
Unknown Object (File)
Thu, Jun 25, 1:18 AM
Unknown Object (File)
Wed, Jun 17, 2:41 PM
Unknown Object (File)
Wed, Jun 17, 3:02 AM
Unknown Object (File)
Fri, Jun 12, 1:53 AM
Unknown Object (File)
Thu, Jun 11, 10:37 AM
Unknown Object (File)
May 18 2026, 12:51 PM
View All Files
Subscribers
None

Details

Reviewers
imp
cem
Commits
rS332123: MFC efivar changes: r321429, r323056-r323057, r323066, r323259-r323260,
rS326658: Ensure that "out" is initialized in all error paths.
Summary

Caught by gcc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Dec 7 2017, 12:01 AM
markj added a reviewer: imp.Dec 7 2017, 12:02 AM
cem accepted this revision.Dec 7 2017, 12:53 AM
This revision is now accepted and ready to land.Dec 7 2017, 12:53 AM
Closed by commit rS326658: Ensure that "out" is initialized in all error paths. (authored by markj). · Explain WhyDec 7 2017, 3:16 PM
This revision was automatically updated to reflect the committed changes.
imp added a comment.Dec 7 2017, 4:38 PM

Thanks for doing this, but please hold off any further changes to the efi stuff. I have it on a couple of branches on a couple of machines tweaking and even trivial changes like this cause me hassles in merging and updating. I'd prefer if you send me stuff like this directly. I don't even recall seeing this review.

Revision Contents
Changeset List

PathSize
head/
lib/
libefivar/
2 lines

Diff 36339

View Options

head/lib/libefivar/efivar-dp-xlate.c

Loading...