Page MenuHomeFreeBSD
Differential D13208

New port: sysutils/hstr: Bash and Zsh shell history suggest box
ClosedPublic
Actions

Authored by yuri on Nov 23 2017, 7:56 AM.

Details

Reviewers
tcberner
adamw
Commits
rP454846: New port: sysutils/hstr: Bash and Zsh shell history suggest box
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223775

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuri created this revision.Nov 23 2017, 7:56 AM
Herald added a subscriber: mat. · View Herald TranscriptNov 23 2017, 7:56 AM
Harbormaster completed remote builds in B12969: Diff 35641.Nov 23 2017, 7:56 AM
yuri updated this revision to Diff 35643.Nov 23 2017, 8:04 AM

.

Harbormaster completed remote builds in B12970: Diff 35643.Nov 23 2017, 8:04 AM
mat added inline comments.Nov 24 2017, 6:16 PM
sysutils/hstr/Makefile
13 ↗(On Diff #35643)

Out of order. See Chapter 14. Order of Variables in Port Makefiles.

yuri updated this revision to Diff 35722.Nov 24 2017, 7:45 PM
yuri marked an inline comment as done.

.

Harbormaster completed remote builds in B13019: Diff 35722.Nov 24 2017, 7:45 PM
yuri added inline comments.Nov 24 2017, 7:45 PM
sysutils/hstr/Makefile
13 ↗(On Diff #35643)

Fixed.
Reported to portlint: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223851

yuri marked an inline comment as done.Nov 24 2017, 7:45 PM
tcberner accepted this revision.Nov 24 2017, 7:57 PM
tcberner added inline comments.
sysutils/hstr/files/patch-src-hstr.c
1 ↗(On Diff #35722)

should be upstreamed if possible

sysutils/hstr/files/patch-src_include_hstr__curses.h
1 ↗(On Diff #35722)

looks like prime upstream material

This revision is now accepted and ready to land.Nov 24 2017, 7:57 PM
yuri marked 2 inline comments as done.Nov 24 2017, 8:04 PM
Closed by commit rP454846: New port: sysutils/hstr: Bash and Zsh shell history suggest box (authored by yuri). · Explain WhyNov 24 2017, 8:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sysutils/
1 line
hstr/
20 lines
3 lines
files/
11 lines
11 lines
11 lines
5 lines

Diff 35730

View Options

head/sysutils/Makefile

Loading...
View Options

head/sysutils/hstr/Makefile

Loading...
View Options

head/sysutils/hstr/distinfo

Loading...
View Options

head/sysutils/hstr/files/patch-src-hstr.c

Loading...
View Options

head/sysutils/hstr/files/patch-src_Makefile.am

Loading...
View Options

head/sysutils/hstr/files/patch-src_include_hstr__curses.h

Loading...
View Options

head/sysutils/hstr/pkg-descr

Loading...