Page MenuHomeFreeBSD
Differential D13198

Fix sign-extension error in adagetparams
ClosedPublic
Actions

Authored by asomers on Nov 22 2017, 10:20 PM.
Tags
None
Referenced Files
F168120258: D13198.id36306.diff
Wed, Aug 26, 11:41 AM
Unknown Object (File)
Fri, Aug 21, 2:06 PM
Unknown Object (File)
Fri, Aug 21, 1:54 PM
Unknown Object (File)
Fri, Aug 21, 1:42 PM
Unknown Object (File)
Thu, Aug 20, 12:35 PM
Unknown Object (File)
Sun, Aug 16, 10:49 AM
Unknown Object (File)
Sun, Aug 16, 10:49 AM
Unknown Object (File)
Sun, Aug 16, 10:49 AM
View All Files
Subscribers
imp

Details

Reviewers
ken
Commits
rS327849: MFC r326624:
rS326624: cam: fix sign-extension error in adagetparams
Summary

Fix sign-extension error in adagetparams

adagetparams contains a sign-extension error that will cause the sector
count to be incorrectly calculated for ATA disks of >=1TiB that still use
CHS addressing. Disks using LBA48 addressing are unaffected.

Reported by: Coverity
CID: 1007296

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Nov 22 2017, 10:20 PM
Herald added a subscriber: imp. · View Herald TranscriptNov 22 2017, 10:20 PM
imp added inline comments.Nov 22 2017, 10:39 PM
sys/cam/ata/ata_da.c
3378 ↗(On Diff #35618)

cut and paste artifact, no? otherwise \ doesn't make sense here.

asomers added inline comments.Dec 4 2017, 10:47 PM
sys/cam/ata/ata_da.c
3378 ↗(On Diff #35618)

<sigh> not a copy/paste bug. That's just me writing too much Ruby and Go.

asomers updated this revision to Diff 36209.Dec 4 2017, 10:48 PM

Fix syntax oddity

Harbormaster completed remote builds in B13336: Diff 36209.Dec 4 2017, 10:48 PM
ken accepted this revision.Dec 6 2017, 4:36 PM

Looks good to me, thanks!

This revision is now accepted and ready to land.Dec 6 2017, 4:36 PM
Closed by commit rS326624: cam: fix sign-extension error in adagetparams (authored by asomers). · Explain WhyDec 6 2017, 5:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
cam/
ata/
3 lines

Diff 36306

View Options

head/sys/cam/ata/ata_da.c

Loading...