Page MenuHomeFreeBSD
Differential D13173

Fix multiple bugs in cam_strmatch
ClosedPublic
Actions

Authored by asomers on Nov 20 2017, 9:41 PM.
Tags
None
Referenced Files
F153379474: D13173.diff
Mon, Apr 20, 7:46 PM
Unknown Object (File)
Sat, Apr 18, 7:32 PM
Unknown Object (File)
Sat, Apr 18, 2:10 PM
Unknown Object (File)
Thu, Apr 9, 2:05 AM
Unknown Object (File)
Tue, Apr 7, 9:28 PM
Unknown Object (File)
Thu, Apr 2, 7:00 AM
Unknown Object (File)
Wed, Apr 1, 10:52 PM
Unknown Object (File)
Wed, Apr 1, 11:37 AM
View All Files
Subscribers
ken

Details

Reviewers
imp
Commits
rS326782: MFC r304443, r326034, r326065
rS326034: Fix multiple bugs in cam_strmatch
Summary

Fix multiple bugs in cam_strmatch

  • Wrongly matches strings that are shorter than the pattern
  • Fails to match negative character sets
  • Fails to match character sets that aren't at the end of the pattern
  • Fails to match character ranges
Test Plan

Added unit tests

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Nov 20 2017, 9:41 PM
Harbormaster completed remote builds in B12891: Diff 35505.Nov 20 2017, 9:41 PM
imp accepted this revision.Nov 20 2017, 9:46 PM

I suspect these same bugs are present in the file globbing code I stole the original implementation from.
Nice catches.

lib/libcam/tests/cam_test.c
91 ↗(On Diff #35505)

There's no pattern like 'fo[a-z][a-z][123]' which has multiple ranges tested.

This revision is now accepted and ready to land.Nov 20 2017, 9:46 PM
asomers added inline comments.Nov 20 2017, 9:59 PM
lib/libcam/tests/cam_test.c
91 ↗(On Diff #35505)

Ok, I'll add one.

Closed by commit rS326034: Fix multiple bugs in cam_strmatch (authored by asomers). · Explain WhyNov 20 2017, 10:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
lib/
libcam/
tests/
1 line
111 lines
2 lines
sys/
cam/
28 lines

Diff 35507

View Options

head/lib/libcam/tests/Makefile

Loading...
View Options

head/lib/libcam/tests/cam_test.c

Loading...
View Options

head/lib/libcam/tests/libcam_test.c

Loading...
View Options

head/sys/cam/cam.c

Loading...