Fix multiple bugs in cam_strmatch
- Wrongly matches strings that are shorter than the pattern
- Fails to match negative character sets
- Fails to match character sets that aren't at the end of the pattern
- Fails to match character ranges
Details
Details
Added unit tests
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I suspect these same bugs are present in the file globbing code I stole the original implementation from.
Nice catches.
| lib/libcam/tests/cam_test.c | ||
|---|---|---|
| 91 ↗ | (On Diff #35505) | There's no pattern like 'fo[a-z][a-z][123]' which has multiple ranges tested. |
| lib/libcam/tests/cam_test.c | ||
|---|---|---|
| 91 ↗ | (On Diff #35505) | Ok, I'll add one. |