Paths

Table of Contentst

Differential D13165

New port: x11/xcape: Configure modifier keys to act as other keys when pressed on their own
ClosedPublic
Actions

Authored by yuri on Nov 20 2017, 3:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Oct 11, 8:34 PM

	Unknown Object (File)
	Thu, Oct 2, 11:35 AM

	Unknown Object (File)
	Mon, Sep 29, 11:10 AM

	Unknown Object (File)
	Mon, Sep 29, 11:09 AM

	Unknown Object (File)
	Mon, Sep 29, 11:09 AM

	Unknown Object (File)
	Thu, Sep 25, 2:40 PM

	Unknown Object (File)
	Tue, Sep 23, 9:35 PM

	Unknown Object (File)
	Thu, Sep 18, 3:22 AM

View All 81 Files

Subscribers

Details

Reviewers

tcberner
adamw

Commits

rP454853: New port: x11/xcape: Configure modifier keys to act as other keys when pressed…

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222602

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Nov 20 2017, 3:20 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 20 2017, 3:20 AM

Harbormaster completed remote builds in B12881: Diff 35485.Nov 20 2017, 3:20 AM

tcberner added inline comments.Nov 22 2017, 6:02 AM

x11/xcape/Makefile
21 ↗	(On Diff #35485)	^ this looks unecessary/wrong

yuri marked an inline comment as done.Nov 22 2017, 6:12 AM

yuri added inline comments.

x11/xcape/Makefile
21 ↗	(On Diff #35485)	Why do you think this is wrong? This makefile has `=`, not `>=`. GNU make has the feature that it still sets such variables (with `=`) when they are placed into make's arguments, but not into its environment. This line exploits this feature. Do you think it's wrong?

yuri marked 2 inline comments as done.Nov 22 2017, 6:12 AM

tcberner added inline comments.Nov 22 2017, 6:22 AM

x11/xcape/Makefile
21 ↗	(On Diff #35485)	MANDIR sounded absolute, and PREFIX unessessary :) looking at the Makefile, you're right.

yuri marked an inline comment as done.Nov 22 2017, 6:31 AM

yuri added inline comments.Nov 22 2017, 6:49 AM

x11/xcape/Makefile
21 ↗	(On Diff #35485)	So, approved?

yuri marked an inline comment as done.Nov 22 2017, 6:49 AM

yuri added a comment.Nov 23 2017, 6:44 AM

This comment was removed by yuri.

indeed

This revision is now accepted and ready to land.Nov 24 2017, 9:54 PM

Closed by commit rP454853: New port: x11/xcape: Configure modifier keys to act as other keys when pressed… (authored by yuri). · Explain WhyNov 24 2017, 10:12 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

x11/

1 line

xcape/

28 lines

3 lines

5 lines

Diff 35743

head/x11/Makefile

Loading...

head/x11/xcape/Makefile

Loading...

head/x11/xcape/distinfo

Loading...

head/x11/xcape/pkg-descr

Loading...