Page MenuHomeFreeBSD

cam/scsi_da: active ssd quirks for all SAMSUNG MZ7* ssd
ClosedPublic

Authored by nikita_elyzion.net on Nov 14 2017, 7:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 4:40 AM
Unknown Object (File)
Mon, Nov 18, 2:54 AM
Unknown Object (File)
Thu, Nov 14, 8:32 AM
Unknown Object (File)
Oct 1 2024, 5:00 AM
Unknown Object (File)
Sep 27 2024, 6:25 PM
Unknown Object (File)
Sep 23 2024, 6:00 AM
Unknown Object (File)
Sep 19 2024, 5:04 AM
Unknown Object (File)
Sep 18 2024, 2:21 PM
Subscribers

Details

Summary

I have just received a big bunch of samsun pm863a SSD. Unfortunately some of them have doesn't contain "SAMSUNG" in the beginning of their name so the current "SAMSUNG MZ7*" quirks is not enabled for them.

[19:36 root@sh-3-11-fbsd][~]# geom disk list da120 
Geom name: da120
Providers:
1. Name: da120
   Mediasize: 960197124096 (894G)
   Sectorsize: 512
   Stripesize: 4096
   Stripeoffset: 0
   Mode: r1w1e2
   descr: ATA SAMSUNG MZ7LM960
   lunid: 5002538c403291cc
   ident: S2E3NX0H601956
   rotationrate: 0
   fwsectors: 63
   fwheads: 255

[19:36 root@sh-3-11-fbsd][~]# geom disk list da121
Geom name: da121
Providers:
1. Name: da121
   Mediasize: 960197124096 (894G)
   Sectorsize: 512
   Mode: r1w1e2
   descr: ATA MZ7LM960HMJP0D3
   lunid: 5002538c404c4568
   ident: S37KNX0HC01189
   rotationrate: 0
   fwsectors: 63
   fwheads: 255

Note that, the SSD look totally identical on disk sticker...
Also, the disk FW is not identical and I cannot find an available FW to flash it but it's another subject.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

don't we also need this same quirk in ata_da.c?

Now that you point it, yes I missed that part!
It will be difficult for me to test it, do you want that I path ata_da.c anyway ?

Now that you point it, yes I missed that part!
It will be difficult for me to test it, do you want that I path ata_da.c anyway ?

Yes please. Compile testing is fine for that.

This points out, however, that artificial names generated by HBAs are a bit of an issue.... :(

The 4k quirk is in serious need of being revisited because we shouldn't have to do this except for a tiny tiny fraction of drives.

In D13093#272417, @imp wrote:

Now that you point it, yes I missed that part!
It will be difficult for me to test it, do you want that I path ata_da.c anyway ?

The 4k quirk is in serious need of being revisited because we shouldn't have to do this except for a tiny tiny fraction of drives.

I totally agree on that.

This revision is now accepted and ready to land.Nov 16 2017, 10:14 AM
This revision was automatically updated to reflect the committed changes.