Page MenuHomeFreeBSD

Backport clang r221170 to implement va_arg support for PowerPC
ClosedPublic

Authored by dim on Dec 13 2014, 10:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 1 2024, 1:27 AM
Unknown Object (File)
Sep 30 2024, 8:06 PM
Unknown Object (File)
Sep 30 2024, 5:58 AM
Unknown Object (File)
Sep 29 2024, 7:13 PM
Unknown Object (File)
Sep 28 2024, 1:22 PM
Unknown Object (File)
Sep 27 2024, 6:01 PM
Unknown Object (File)
Sep 21 2024, 7:44 AM
Unknown Object (File)
Sep 20 2024, 10:19 PM
Subscribers
None

Details

Summary

Pull in r221170 from upstream clang trunk (by Roman Divacky):

Implement vaarg lowering for ppc32. Lowering of scalars and
aggregates is supported. Complex numbers are not.
Test Plan

Since I have no way of knowing whether this works correctly or not, I would like both a sanity check, and a check that this results in working va_args support on real PowerPC hardware.

I did build it, both with clang and gcc (I had to remove one C++11-ism), and it should compile OK.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dim retitled this revision from to Backport clang r221170 to implement va_arg support for PowerPC.
dim updated this object.
dim edited the test plan for this revision. (Show Details)
dim added reviewers: jhibbits, nwhitehorn.
jhibbits edited edge metadata.

Just tested, it passes the llvm upstream ppc-varargs-struct.c test. Thanks for merging it!

This revision is now accepted and ready to land.Dec 14 2014, 5:29 AM
dim updated this revision to Diff 2744.

Closed by commit rS275759 (authored by @dim).