tests
ClosedPublic
Actions

Authored by ngie on Dec 12 2014, 10:24 PM.

Details

Reviewers

Summary

This is a diff under test for fixing the case when TESTSBASE != /usr/tests, as noticed when I tried to change this to a custom prefix at EMC / Isilon.

make buildworld/make installworld was run and was successful when executed from a chroot; unfortunately running kyua test doesn't work all that well when executed from an absolute path if DESTDIR != / (but that's a separate commit that needs to be done, potentially).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ngie updated this revision to Diff 2721.Dec 12 2014, 10:24 PM

ngie retitled this revision from to Fix building/installing tests when TESTSBASE != /usr/tests.

ngie updated this object.

ngie edited the test plan for this revision. (Show Details)

ngie added a subscriber: bdrewery.

benno added a subscriber: benno.Dec 12 2014, 10:29 PM

This doesn't fix make delete-old :(. That I'll need to tackle in another commit...

Catch the simple case when dealing with TESTSBASE != /usr/tests in make delete-old

The more complex case will need fudging with make

Adjust BSD.tests.dist to no longer assume that tests is the last component in
the path

Adjust all calls to mtree with the file accordingly

ngie updated this object.Dec 13 2014, 3:20 AM

ngie added subscribers: tests, imp.

Ping?

This is OK, but does infect the base system with ATF. Not the worst outcome in the world as it also fixes issues with tests augmenting directories that should be specified with other files.

This revision is now accepted and ready to land.Dec 17 2014, 11:01 PM

Committed in r275907 -- thank you :)!