ports-mgmt/portlint/src/portlint.pl
1482–1483	Mmmm, this is backwards. The idea behind `%%FOO%%` placeholders is to carry variables from the dynamic Makefile to the static pkg-plist file. As `PLIST_FILE` is defined in the Makefile, it does not need to have %%FOO%% placeholders, it can simply use `${FOO}`. (or whatever `%%FOO%%` is made of.)

@mat is right here, we should not add %%FOO%% in the PLIST_FILE at all.

ports-mgmt/portlint/src/portlint.pl
1482–1483	The wording can be changed, but would it be a good style to use for ex. `${PORTDOCS}${DOCSDIR}/README` in PLIST_FILES? Or, in comms/tio case, `${BASH}share/bash-completion/completions/tio`? The idea was that if porter needs to use %%FOO%%, they need to use pkg-plist intead of PLIST_FILES.

mat added inline comments.Nov 9 2017, 3:52 PM

ports-mgmt/portlint/src/portlint.pl
1482–1483	In this case, `%%PORTDOCS%%` is handled by the `DOCS` option, so it could be written as: DOCS_PLIST_FILES= ${DOCSDIR}/README But there is a variable that makes it even shorter: PORTDOCS= README As for `%%BASH%%`, it is generated by the `OPTIONS_SUB` knob, and it should be written as: BASH_PLIST_FILES= share/bash-completion/completions/tio I already wrote all this in the review that spawned the PR that spawned this code review.