Page MenuHomeFreeBSD

comms/tio: Update to 1.26

Authored by yuri on Nov 8 2017, 12:02 AM.
Referenced Files
Unknown Object (File)
Sat, Nov 18, 5:14 PM
Unknown Object (File)
Nov 10 2023, 1:30 AM
Unknown Object (File)
Nov 5 2023, 5:22 AM
Unknown Object (File)
Nov 3 2023, 4:40 AM
Unknown Object (File)
Oct 9 2023, 12:25 AM
Unknown Object (File)
Oct 1 2023, 4:38 AM
Unknown Object (File)
Sep 26 2023, 6:02 AM
Unknown Object (File)
Sep 26 2023, 6:01 AM

Diff Detail

rP FreeBSD ports repository
Lint Not Applicable
Tests Not Applicable

Event Timeline

tcberner added inline comments.
26 ↗(On Diff #34907)

^ I sometimes wonder wheter a single file is really worth an OPTION ^^ -- not really related ^^

This revision is now accepted and ready to land.Nov 8 2017, 6:32 AM
yuri marked an inline comment as done.Nov 8 2017, 6:35 AM
yuri added inline comments.
26 ↗(On Diff #34907)

Some people want to install all BASH bindings, so that they can just set BASH=yes for everything. It's nice IMO, even though it's just one file. :)

This revision was automatically updated to reflect the committed changes.
yuri marked an inline comment as done.
26 ↗(On Diff #34907)

Yes, but those who don't hopeuflly have other things to worry about than a 2.2k text file more on there disk ^^ -- what I was suggesting is to always just install such things :)

Yes, I know, but where do you draw the line? Having an option is certainly very beneficial when it enables/disables large parts. Some more pedantically-inclined people with argue that it's warranted even for such small single files. Packages in Gentoo linux, I think, do this a lot. There is likely no consensus on this in the computer community. :)


Never, ever, put %%FOO%% in PLIST_FILES. The idea behind %%FOO%% placeholders is to allow one to carry variables from the Makefile to the pkg-plist file. Here, you are in the Makefile, simply use the variables, or in that case, do it the way the framework helps you to do it:

PLIST_FILES=        bin/tio \
BASH_PLIST_FILES=   share/bash-completion/completions/tio

Also, whenever you install files in DOCSDIR, you MUST add a DOCS option.

I am STRONGLY in favour of more options. Even if it's a 1-file change. Give people choice and control. This is BSD, after all.

I created the request for portlint to complain about %%FOO%% in PLIST_FILES:

I've asked portlint to require DOCS when %%PORTDOCS%% is used in plist:

So do I have an approval to change these two items:

  • Restore pkg-plist and remove PKG_PLIST from Makefile
  • Add DOCS to options


yuri marked an inline comment as done.Nov 8 2017, 6:08 PM