Page MenuHomeFreeBSD

comms/tio: Update to 1.26
ClosedPublic

Authored by yuri on Nov 8 2017, 12:02 AM.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuri created this revision.Nov 8 2017, 12:02 AM
tcberner accepted this revision.Nov 8 2017, 6:32 AM
tcberner added inline comments.
comms/tio/Makefile
26 ↗(On Diff #34907)

^ I sometimes wonder wheter a single file is really worth an OPTION ^^ -- not really related ^^

This revision is now accepted and ready to land.Nov 8 2017, 6:32 AM
yuri marked an inline comment as done.Nov 8 2017, 6:35 AM
yuri added inline comments.
comms/tio/Makefile
26 ↗(On Diff #34907)

Some people want to install all BASH bindings, so that they can just set BASH=yes for everything. It's nice IMO, even though it's just one file. :)

yuri marked an inline comment as done.Nov 8 2017, 6:38 AM
Closed by commit rP453720: comms/tio: Update to 1.26 (authored by yuri). · Explain Why
This revision was automatically updated to reflect the committed changes.
tcberner added inline comments.Nov 8 2017, 6:45 AM
comms/tio/Makefile
26 ↗(On Diff #34907)

Yes, but those who don't hopeuflly have other things to worry about than a 2.2k text file more on there disk ^^ -- what I was suggesting is to always just install such things :)

yuri added a comment.Nov 8 2017, 6:54 AM

Yes, I know, but where do you draw the line? Having an option is certainly very beneficial when it enables/disables large parts. Some more pedantically-inclined people with argue that it's warranted even for such small single files. Packages in Gentoo linux, I think, do this a lot. There is likely no consensus on this in the computer community. :)

mat added inline comments.Nov 8 2017, 12:49 PM
head/comms/tio/Makefile
26–27

Never, ever, put %%FOO%% in PLIST_FILES. The idea behind %%FOO%% placeholders is to allow one to carry variables from the Makefile to the pkg-plist file. Here, you are in the Makefile, simply use the variables, or in that case, do it the way the framework helps you to do it:

PLIST_FILES=        bin/tio \
	            man/man1/tio.1.gz
BASH_PLIST_FILES=   share/bash-completion/completions/tio
PORTDOCS            README

Also, whenever you install files in DOCSDIR, you MUST add a DOCS option.

adamw added a comment.Nov 8 2017, 1:26 PM

I am STRONGLY in favour of more options. Even if it's a 1-file change. Give people choice and control. This is BSD, after all.

yuri added a comment.Nov 8 2017, 5:25 PM

I created the request for portlint to complain about %%FOO%% in PLIST_FILES: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223539

yuri added a comment.Nov 8 2017, 6:00 PM

I've asked portlint to require DOCS when %%PORTDOCS%% is used in plist: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223541

yuri added a comment.Nov 8 2017, 6:02 PM

So do I have an approval to change these two items:

  • Restore pkg-plist and remove PKG_PLIST from Makefile
  • Add DOCS to options

?

yuri marked an inline comment as done.Nov 8 2017, 6:08 PM