devel/py-natsort: Update to 5.1.0
ClosedPublic
Actions

Authored by yuri on Nov 4 2017, 6:26 PM.

Details

Reviewers

tcberner
adamw

Commits

rP453724: devel/py-natsort: Removed RUN_DEPENDS from TEST_DEPENDS.
rP453478: devel/py-natsort: Update to 5.1.0

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223106

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Nov 4 2017, 6:26 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 4 2017, 6:26 PM

Harbormaster completed remote builds in B12453: Diff 34768.Nov 4 2017, 6:26 PM

tcberner added inline comments.Nov 4 2017, 6:37 PM

devel/py-natsort/Makefile
4 ↗	(On Diff #34768)	^DISTVERSION

DISTVERSION.

yuri marked an inline comment as done.Nov 4 2017, 6:40 PM

Looks good to me.

This revision is now accepted and ready to land.Nov 4 2017, 7:21 PM

Closed by commit rP453478: devel/py-natsort: Update to 5.1.0 (authored by yuri). · Explain WhyNov 4 2017, 7:28 PM

This revision was automatically updated to reflect the committed changes.

mat added inline comments.Nov 7 2017, 4:24 PM

head/devel/py-natsort/Makefile
22	The test phase is ran after the port is installed, so RUN_DEPENDS are always there, no need to add them to TEST_DEPENDS.

yuri marked an inline comment as done.Nov 7 2017, 5:00 PM

yuri added inline comments.

head/devel/py-natsort/Makefile
22	Can I just commit the correction, or I need to create a differential for approval?

yuri marked 2 inline comments as done.Nov 7 2017, 5:02 PM

Approved :)

Revision Contents
Changeset List

Path

Size

head/

devel/

py-natsort/

Makefile

16 lines

distinfo

6 lines

Diff 34776

View Options

head/devel/py-natsort/Makefile