Details

Reviewers

tcberner
adamw

Commits

rP464149: New port: math/mathgl: Library for high-quality scientific data visualization

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=222471

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Nov 1 2017, 8:03 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 1 2017, 8:03 AM

yuri added a reviewer: adamw.Nov 1 2017, 9:04 AM

tcberner added inline comments.Nov 1 2017, 6:20 PM

math/mathgl/Makefile
23 ↗	(On Diff #34583)	You could alphabetize them, i.e. USE_GL before USE_XORG.
36 ↗	(On Diff #34583)	you can leave out the _DESC's for everything that is in `Mk/bsd.options.desc.mk`. PYTHON QT5 WXGTK
43 ↗	(On Diff #34583)	^probably `qmake_build` suffices. Normally I tend to alphabetize the components... (by groups, normal-, build-, and run-depends), i.e. `QT5=core,gui,opengl,printsupport,widgets,buildtools_build,qmake_build`. Just makes it a tad quicker to look for something.

yuri updated this revision to Diff 34637.Nov 1 2017, 9:06 PM

yuri marked 3 inline comments as done.

mat added inline comments.Nov 2 2017, 2:42 PM

math/mathgl/Makefile
6 ↗	(On Diff #34637)	SF/${PORTNAME}/files/${PORTNAME}/${PORTNAME}%20${PORTVERSION}
21 ↗	(On Diff #34637)	python:2.7
47 ↗	(On Diff #34637)	Should be earlier. and the "options" block can get more spaces between its sections. See 14.9. Options and Helpers

yuri marked 3 inline comments as done.Nov 2 2017, 5:09 PM

yuri added inline comments.

math/mathgl/Makefile
6 ↗	(On Diff #34637)	It doesn't fetch with this MASTER_SITES.

Reviewers: tcberner, adamw

Harbormaster completed remote builds in B12404: Diff 34685.Nov 2 2017, 5:10 PM

mat added inline comments.Nov 2 2017, 10:59 PM

math/mathgl/Makefile
6 ↗	(On Diff #34637)	Can you post the difference of `make fetch-urlall-list` with your version and with mine ?

yuri added inline comments.Nov 3 2017, 5:00 AM

math/mathgl/Makefile

6 ↗

(On Diff #34637)

< https://sourceforge.net/projects/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
---
> https://downloads.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://cytranet.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://excellmedia.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://freefr.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://jaist.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://kent.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://nchc.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://netcologne.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://netix.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://superb-dca2.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://superb-sea2.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://ufpr.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> https://vorboss.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://downloads.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://cytranet.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://excellmedia.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://freefr.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://jaist.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://kent.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://nchc.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://netcologne.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://netix.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://superb-dca2.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://superb-sea2.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://ufpr.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz
> http://vorboss.dl.sourceforge.net/project/mathgl/files/mathgl/mathgl%202.4.1/mathgl-2.4.1.tar.gz

mat added inline comments.Nov 3 2017, 11:47 AM

math/mathgl/Makefile
6 ↗	(On Diff #34637)	Ok, so, looking at where your hand crafted url redirects to: SF/${PORTNAME}/${PORTNAME}/${PORTNAME}%20${PORTVERSION}

yuri marked an inline comment as done.Nov 3 2017, 4:09 PM

yuri added inline comments.

math/mathgl/Makefile
6 ↗	(On Diff #34637)	This works, thanks!

Updated MASTER_SITES as per Matt's suggestion.

tcberner added inline comments.Nov 7 2017, 10:34 PM

math/mathgl/Makefile
19 ↗	(On Diff #34724)	^ please sort these
21 ↗	(On Diff #34724)	^ cmake:outsoruce if it works :)
45 ↗	(On Diff #34637)	^ this could also use some sorting
math/mathgl/pkg-plist
53 ↗	(On Diff #34724)	you could maybe add an `PLIST_SUB=SHLIB_VER=7.5.0`, and replace all these here by `%%SHLIB_VER%%` which could reduce the diff for further updates.

tcberner added inline comments.Nov 7 2017, 10:35 PM

math/mathgl/Makefile
45 ↗	(On Diff #34637)	sorry, this was unsubmitted from a previous run through... and I think it belonged to the XORG=x11,sm,xext,ice one

yuri marked 4 inline comments as done.Nov 11 2017, 9:03 AM

yuri marked 5 inline comments as done.Nov 11 2017, 9:10 AM

tcberner added inline comments.Nov 18 2017, 10:43 AM

math/mathgl/Makefile
21 ↗	(On Diff #34724)	I assume it did not work? :D
23 ↗	(On Diff #34724)	`xi xmu` -- if the ports start out sorted, it's easier to add new dependencies :)
math/mathgl/pkg-plist
53 ↗	(On Diff #34724)	that's not done :D

Sorry, I must have forgotten to update the diff.
Of course, cmake:outsource worked. :)

yuri marked 3 inline comments as done.Nov 18 2017, 4:51 PM

It fails to stage for me:

===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%DATADIR%%/fonts/STIX.vfm
Error: Missing: %%DATADIR%%/fonts/STIX_b.vfm
Error: Missing: %%DATADIR%%/fonts/STIX_bi.vfm
Error: Missing: %%DATADIR%%/fonts/STIX_i.vfm
Error: Missing: %%DATADIR%%/fonts/adventor.vfm
Error: Missing: %%DATADIR%%/fonts/adventor_b.vfm
Error: Missing: %%DATADIR%%/fonts/adventor_bi.vfm
Error: Missing: %%DATADIR%%/fonts/adventor_i.vfm
Error: Missing: %%DATADIR%%/fonts/bonum.vfm
Error: Missing: %%DATADIR%%/fonts/bonum_b.vfm
Error: Missing: %%DATADIR%%/fonts/bonum_bi.vfm
Error: Missing: %%DATADIR%%/fonts/bonum_i.vfm
Error: Missing: %%DATADIR%%/fonts/chorus.vfm
Error: Missing: %%DATADIR%%/fonts/cursor.vfm
Error: Missing: %%DATADIR%%/fonts/cursor_b.vfm
Error: Missing: %%DATADIR%%/fonts/cursor_bi.vfm
Error: Missing: %%DATADIR%%/fonts/cursor_i.vfm
Error: Missing: %%DATADIR%%/fonts/heros.vfm
Error: Missing: %%DATADIR%%/fonts/heros_b.vfm
Error: Missing: %%DATADIR%%/fonts/heros_bi.vfm
Error: Missing: %%DATADIR%%/fonts/heros_i.vfm
Error: Missing: %%DATADIR%%/fonts/heroscn.vfm
Error: Missing: %%DATADIR%%/fonts/heroscn_b.vfm
Error: Missing: %%DATADIR%%/fonts/heroscn_bi.vfm
Error: Missing: %%DATADIR%%/fonts/heroscn_i.vfm
Error: Missing: %%DATADIR%%/fonts/pagella.vfm
Error: Missing: %%DATADIR%%/fonts/pagella_b.vfm
Error: Missing: %%DATADIR%%/fonts/pagella_bi.vfm
Error: Missing: %%DATADIR%%/fonts/pagella_i.vfm
Error: Missing: %%DATADIR%%/fonts/schola.vfm
Error: Missing: %%DATADIR%%/fonts/schola_b.vfm
Error: Missing: %%DATADIR%%/fonts/schola_bi.vfm
Error: Missing: %%DATADIR%%/fonts/schola_i.vfm
Error: Missing: %%DATADIR%%/fonts/termes.vfm
Error: Missing: %%DATADIR%%/fonts/termes_b.vfm
Error: Missing: %%DATADIR%%/fonts/termes_bi.vfm
Error: Missing: %%DATADIR%%/fonts/termes_i.vfm
===> Error: Plist issues found.
*** Error code 1

This revision was not accepted when it landed; it landed in state Needs Review.Mar 11 2018, 8:39 AM

Closed by commit rP464149: New port: math/mathgl: Library for high-quality scientific data visualization (authored by yuri). · Explain Why

This revision was automatically updated to reflect the committed changes.

New port: math/mathgl: Library for high-quality scientific data visualization
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 40151

head/math/Makefile

head/math/mathgl/Makefile

head/math/mathgl/distinfo

head/math/mathgl/files/patch-CMakeLists.txt

head/math/mathgl/files/patch-examples_CMakeLists.txt

head/math/mathgl/files/patch-src_CMakeLists.txt

head/math/mathgl/files/patch-widgets_CMakeLists.txt

head/math/mathgl/files/patch-widgets_qt4_CMakeLists.txt

head/math/mathgl/files/patch-widgets_qt5_CMakeLists.txt

head/math/mathgl/pkg-descr

head/math/mathgl/pkg-plist

New port: math/mathgl: Library for high-quality scientific data visualizationClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40151

head/math/Makefile

head/math/mathgl/Makefile

head/math/mathgl/distinfo

head/math/mathgl/files/patch-CMakeLists.txt

head/math/mathgl/files/patch-examples_CMakeLists.txt

head/math/mathgl/files/patch-src_CMakeLists.txt

head/math/mathgl/files/patch-widgets_CMakeLists.txt

head/math/mathgl/files/patch-widgets_qt4_CMakeLists.txt

head/math/mathgl/files/patch-widgets_qt5_CMakeLists.txt

head/math/mathgl/pkg-descr

head/math/mathgl/pkg-plist

New port: math/mathgl: Library for high-quality scientific data visualization
ClosedPublic
Actions

Revision Contents
Changeset List