Page MenuHomeFreeBSD

New port: x11-toolkits/ntk: Fork of FLTK 1.3.0 which adds graphics rendering via Cairo, etc
ClosedPublic

Authored by yuri on Nov 1 2017, 7:40 AM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 27 2024, 8:19 AM
Unknown Object (File)
Apr 27 2024, 8:19 AM
Unknown Object (File)
Apr 27 2024, 8:19 AM
Unknown Object (File)
Apr 27 2024, 8:19 AM
Unknown Object (File)
Apr 27 2024, 7:06 AM
Unknown Object (File)
Apr 27 2024, 6:52 AM
Unknown Object (File)
Apr 26 2024, 2:40 AM
Unknown Object (File)
Apr 26 2024, 2:40 AM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

x11-toolkits/ntk/Makefile
16 ↗(On Diff #34581)

^ I would sort this

18 ↗(On Diff #34581)

^ I would sort this.

22 ↗(On Diff #34581)

USE_GNOME before USE_XORG (again, no rule, but when you create a new port, you can make it tidy :D )

yuri marked 3 inline comments as done.
x11-toolkits/ntk/Makefile
18 ↗(On Diff #34631)

Keep this sorted.

yuri marked an inline comment as done.Nov 2 2017, 3:47 PM

Reviewers: tcberner, adamw

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: lib/libntk.so.1.3.1000
Error: Orphaned: lib/libntk_images.so.1.3.1000
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: lib/libntk.so.1.3.0
Error: Missing: lib/libntk_images.so.1.3.0
This revision now requires changes to proceed.Nov 4 2017, 12:40 PM
x11-toolkits/ntk/pkg-plist
155 ↗(On Diff #34745)

as this is probably bound to the DISTVERSION, you could add a PLIST_SUB for this. That way, if you're lucky, you don't even have to touch the plist on a port-update.

Something like PLIST_SUB= SHLIB_VER=${DISTVERSION} and replace the 1.3.1000's with %%SHLIB_VER%%

yuri marked an inline comment as done.

Added PLIST_SUB= SHLIB_VER=${DISTVERSION}

PLIST_SUB= SHLIB_VER=${DISTVERSION}

This revision is now accepted and ready to land.Nov 4 2017, 7:45 PM
This revision was automatically updated to reflect the committed changes.