Page MenuHomeFreeBSD

Ensure random_source_descr[] does not get out of sync
Needs ReviewPublic

Authored by obrien on Oct 27 2017, 10:05 PM.

Details

Reviewers
delphij
jmg
Summary

Ensure random_source_descr[] does not get out of sync with
'enum random_entropy_source'.

Diff Detail

Repository
rS FreeBSD src repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12409
Build 12685: arc lint + arc unit

Event Timeline

obrien created this revision.Oct 27 2017, 10:05 PM
obrien retitled this revision from <<Replace this line with your revision title> Ensure random_source_descr[] does not get out of sync to Ensure random_source_descr[] does not get out of sync.Oct 27 2017, 10:30 PM

The change itself looks Okay to me, but I might have missed some background discussion -- why do we need to CTASSERT for something already defined in that way a few lines above?

sys/dev/random/random_harvestq.c
285 ↗(On Diff #34412)

It's probably worthy to add a comment here?

obrien added a comment.Nov 2 2017, 8:50 PM

No you didn't miss anything. Bug in my forward porting of this change from just before r324393 to after. I'll upload an updated diff. With r324393 we can still have the r260847 & r303035 bugs.

obrien updated this revision to Diff 34697.Nov 2 2017, 8:51 PM

Address delphij's comment.

jmg added a comment.Dec 23 2017, 1:54 AM

I don't see an issue with this change, looks good to me.