Page MenuHomeFreeBSD
Differential D12810

Give a DEV_ERROR for options with invalid characters.
ClosedPublic
Actions

Authored by mat on Oct 27 2017, 2:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 24 2024, 11:18 PM
Unknown Object (File)
Oct 2 2024, 8:27 PM
Unknown Object (File)
Oct 1 2024, 1:50 PM
Unknown Object (File)
Sep 30 2024, 11:40 PM
Unknown Object (File)
Sep 30 2024, 1:59 AM
Unknown Object (File)
Sep 28 2024, 2:32 AM
Unknown Object (File)
Sep 25 2024, 4:19 AM
Unknown Object (File)
Sep 20 2024, 2:00 PM
View All 54 Files
Subscribers
bapt

Details

Reviewers
bapt
Group Reviewers
portmgr
Commits
rP453347: Add a check for options names.
Test Plan

Wonder if an exp-run is needed or if I can do it myself as nothing needs to be
built here.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat created this revision.Oct 27 2017, 2:18 PM
Harbormaster completed remote builds in B12262: Diff 34394.Oct 27 2017, 2:18 PM
mat updated this revision to Diff 34395.Oct 27 2017, 2:21 PM

typo.

Harbormaster completed remote builds in B12263: Diff 34395.Oct 27 2017, 2:22 PM
mat updated this revision to Diff 34396.Oct 27 2017, 2:30 PM
  • Try this with a port that does not have options.
mat updated this revision to Diff 34401.Oct 27 2017, 4:13 PM
  • Move to a DEV_WARNING.
Harbormaster completed remote builds in B12267: Diff 34401.Oct 27 2017, 4:13 PM
mat added a comment.Oct 27 2017, 4:32 PM

There are 19 ports that report this.

If I add - it goes down to 15.

mat added inline comments.Oct 30 2017, 3:12 PM
Mk/bsd.port.mk
4668 ↗(On Diff #34401)

So, this also only works on 11.0+, and not on 10.3.

mat updated this revision to Diff 34538.Oct 31 2017, 2:06 PM
  • Globs don't work on 10, do it some other way.
Harbormaster completed remote builds in B12331: Diff 34538.Oct 31 2017, 2:06 PM
bapt accepted this revision.Nov 2 2017, 3:09 PM
bapt added a subscriber: bapt.

LGTM

This revision is now accepted and ready to land.Nov 2 2017, 3:09 PM
Closed by commit rP453347: Add a check for options names. (authored by mat). · Explain WhyNov 2 2017, 3:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizePackages
head/
Mk/
18 linesO5: Ports Framework

Diff 34678

View Options

head/Mk/bsd.port.mk

Loading...