devel/codeblocks-devel: new port
ClosedPublic
Actions

Authored by pizzamig on Oct 26 2017, 10:11 PM.

Details

Reviewers

lme
olivier

Commits

rP452969: devel/codeblocks-devel: new port

Summary

devel/codeblocks-devel: new port

PR\: 221703
Submitted by\: lbartoletti@tuxfamily.org
Approved by\: lme (mentor)
Approved by\: olivier (mentor)
Differential Revision\: https://reviews.freebsd.org/DXXXXX

Test Plan

portlint is quite fine
poudriere build on 10.3 10.4 11.0 11.1 on i386 amd64

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 12254
Build 12545: arc lint + arc unit

Event Timeline

pizzamig created this revision.Oct 26 2017, 10:11 PM

Herald added a subscriber: mat. · View Herald TranscriptOct 26 2017, 10:11 PM

After adding a new port, you need to add it to the category Makefile too (here in devel/Makefile): I didn't see modifications to devel/Makefile here.
And each time I'm touching such category Makefile file, I'm checking index is still building fine with an indexbuild (cd /usr/port; make index).

This revision now requires changes to proceed.Oct 27 2017, 5:45 AM

Add the missing entry in the category's Makefile

'make index' shows no error

Harbormaster completed remote builds in B12260: Diff 34387.Oct 27 2017, 8:05 AM

olivier accepted this revision.Oct 27 2017, 8:21 AM

This revision is now accepted and ready to land.Oct 27 2017, 8:21 AM

Closed by commit rP452969: devel/codeblocks-devel: new port (authored by pizzamig). · Explain WhyOct 27 2017, 10:15 AM

This revision was automatically updated to reflect the committed changes.

mat added inline comments.Oct 27 2017, 3:55 PM

head/devel/codeblocks-devel/Makefile
8 ↗	(On Diff #34389)	This cannot possibly do anything as-is. Also, never use a MASTER_SITE_xx variable directly in a port's Makefile.
32 ↗	(On Diff #34389)	What is this for ? it is not used at all.