Fix a racy VI_DOOMED check in MNT_VNODE_FOREACH_ALL()
ClosedPublic
Actions

Authored by markj on Oct 17 2017, 5:51 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Mar 23, 3:29 PM

	Unknown Object (File)
	Sun, Mar 9, 4:20 PM

	Unknown Object (File)
	Mar 6 2025, 2:42 PM

	Unknown Object (File)
	Mar 6 2025, 1:09 PM

	Unknown Object (File)
	Mar 4 2025, 7:48 AM

	Unknown Object (File)
	Feb 14 2025, 11:13 AM

	Unknown Object (File)
	Feb 11 2025, 2:07 PM

	Unknown Object (File)
	Feb 11 2025, 11:10 AM

View All 58 Files

Subscribers

None

Details

Reviewers

kib
mckusick

Commits

rS324704: Fix a racy VI_DOOMED check in MNT_VNODE_FOREACH_ALL().

Summary

MNT_VNODE_FOREACH_ALL() is supposed to avoid returning doomed vnodes,
but the VI_DOOMED check it uses is done without the vnode interlock
held.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Oct 17 2017, 5:51 PM

Harbormaster completed remote builds in B12090: Diff 34071.Oct 17 2017, 5:51 PM

markj added reviewers: kib, mckusick.Oct 17 2017, 5:53 PM

kib accepted this revision.Oct 17 2017, 6:11 PM

This revision is now accepted and ready to land.Oct 17 2017, 6:11 PM

mckusick accepted this revision.Oct 17 2017, 7:13 PM

Closed by commit rS324704: Fix a racy VI_DOOMED check in MNT_VNODE_FOREACH_ALL(). (authored by markj). · Explain WhyOct 17 2017, 7:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

vfs_subr.c

40 lines

Diff 34074

View Options

Fix a racy VI_DOOMED check in MNT_VNODE_FOREACH_ALL()ClosedPublicActions