Add missing locking to oce driver
AbandonedPublic
Actions

Authored by smh on Dec 5 2014, 1:56 PM.

Details

Reviewers

• hselasky
delphij

Summary

Currenlty the oce driver is causing panics when processing tcp_lro_flush commands as noted by:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183391

This patch submitted by Stefano Garzarella adds additional locking which has been tested to prevent this.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

smh updated this revision to Diff 2646.Dec 5 2014, 1:56 PM

smh retitled this revision from to Add missing locking to oce driver.

smh updated this object.

smh edited the test plan for this revision. (Show Details)

smh added reviewers: • hselasky, delphij.Dec 5 2014, 1:58 PM

One missing newline before "{" after oce_tx_clean

Style (9) fix

Patch looks good. Are not able to test it on real hardware though.

Thanks Hans, if you could accept the revision from the "Action" list above the comment block that would be most appreciated.

• hselasky accepted this revision.Dec 5 2014, 3:59 PM

• hselasky edited edge metadata.

This revision is now accepted and ready to land.Dec 5 2014, 3:59 PM

Looks fine.

It has been confirmed that r268156 fixes the issues which sparked this revision but had not been MFC'ed to stable/10.

I've just committed this as r276010 so abandoning this revision.

Revision Contents
Changeset List

Path

Size

sys/

dev/

oce/

oce_if.c

24 lines

oce_queue.c

5 lines

Diff 2650

View Options

sys/dev/oce/oce_if.c