Page MenuHomeFreeBSD

Add missing locking to oce driver
AbandonedPublic

Authored by smh on Dec 5 2014, 1:56 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 11, 6:46 AM
Unknown Object (File)
Jan 30 2024, 9:52 PM
Unknown Object (File)
Jan 5 2024, 9:28 PM
Unknown Object (File)
Jan 5 2024, 9:28 PM
Unknown Object (File)
Jan 5 2024, 9:16 PM
Unknown Object (File)
Dec 27 2023, 8:55 PM
Unknown Object (File)
Dec 27 2023, 8:55 PM
Unknown Object (File)
Dec 19 2023, 11:41 PM
Subscribers
None

Details

Summary

Currenlty the oce driver is causing panics when processing tcp_lro_flush commands as noted by:
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=183391

This patch submitted by Stefano Garzarella adds additional locking which has been tested to prevent this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

smh retitled this revision from to Add missing locking to oce driver.
smh updated this object.
smh edited the test plan for this revision. (Show Details)

One missing newline before "{" after oce_tx_clean

smh edited edge metadata.

Style (9) fix

Patch looks good. Are not able to test it on real hardware though.

Thanks Hans, if you could accept the revision from the "Action" list above the comment block that would be most appreciated.

This revision is now accepted and ready to land.Dec 5 2014, 3:59 PM
delphij edited edge metadata.

Looks fine.

It has been confirmed that r268156 fixes the issues which sparked this revision but had not been MFC'ed to stable/10.

I've just committed this as r276010 so abandoning this revision.