Differential D12676

evdev: several minor fixes and improvements
ClosedPublic
Actions

Authored by wulf on Oct 14 2017, 8:44 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Oct 10, 12:26 AM

	Unknown Object (File)
	Fri, Oct 3, 8:55 AM

	Unknown Object (File)
	Fri, Sep 26, 3:59 AM

	Unknown Object (File)
	Wed, Sep 24, 8:27 PM

	Unknown Object (File)
	Wed, Sep 24, 7:31 PM

	Unknown Object (File)
	Wed, Sep 24, 6:44 PM

	Unknown Object (File)
	Wed, Sep 24, 5:09 PM

	Unknown Object (File)
	Sun, Sep 21, 7:33 PM

View All 65 Files

Subscribers

Details

Reviewers

Commits

rS325299: evdev: Do not start/stop softrepeat callout if no clients attached
rS325298: evdev: Disable value normalization and state filtering for SND events.
rS325297: sysmouse(4): Fix ums(4)-style T-axis reporting via evdev protocol
rS325296: evdev: Take driver's lock in cdev write handler if necessary
rS325295: evdev: Lock Giant around keyboard ioctls
rS325294: evdev: Hide "kern.evdev.rcpt_mask" sysctl if kernel is compiled

Summary

1.Hide "kern.evdev.rcpt_mask" sysctl if kernel is compiled w/o EVDEV_SUPPORT

It can be used for discovery if evdev support for hybrid devices is compiled
into kernel or not. Hide "kern.evdev.sysmouse_t_axis" sysctl as well.

Lock Giant around keyboard ioctls This fixes turning ukbd(4) LEDs on/off with evdev interface as well
Take driver's lock in cdev write handler if necessary
Fixes to ums-style sysmouse(4) T-axis support Do not report T-axis wheel as button presses Reverse T-axis to match Linux Remove wrong comment
Disable value normalization and state filtering for SND events. Some events can take sound pitch as a value so can not be represented as binary on/off events. Tracking for on/off state is left in place as it is a part of the evdev API.
Do not start/stop softrepeat callout if no clients attached.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wulf created this revision.Oct 14 2017, 8:44 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 14 2017, 8:44 PM

Unfortunately, phabricator hangs if I try to upload full-context diff, so standard 3-line context diff is uploaded.

LGTM

This revision is now accepted and ready to land.Nov 1 2017, 7:35 PM

Closed by commit rS325294: evdev: Hide "kern.evdev.rcpt_mask" sysctl if kernel is compiled (authored by wulf). · Explain WhyNov 1 2017, 10:09 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

evdev/

2 lines

Diff 34644

head/sys/dev/evdev/evdev.c

Loading...