Support for Kabylake PMC
ClosedPublic
Actions

Authored by br on Oct 13 2017, 12:30 PM.

Details

Reviewers

emaste
kib

Commits

rS324598: o Support for Kabylake CPU PMCs (fall down to PMC_CPU_INTEL_SKYLAKE).

Summary

Support for 7th Generation Intel® Core (TM)

Test Plan

Tested on ThinkPad X1 Carbon 2017

pmctest.py test passed as well

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br created this revision.Oct 13 2017, 12:30 PM

Indicate Intel document number CPU model comes from

emaste added a subscriber: kib.Oct 13 2017, 12:56 PM

Is there a single IAPDESCR in your patch which contains only one of two flags IAP_F_SL and IAP_F_KL ? I mean that SDM lists desktop Skylake and Kabylake core events in the same table.

If IAP_F_KL just duplicates IAP_F_SL, the patch should be reduced to making Kabylake cpuids to fall to the skylake cputype.

rework patch

kib accepted this revision.Oct 13 2017, 1:57 PM

kib added inline comments.

sys/dev/hwpmc/hwpmc_core.c
723 ↗	(On Diff #33948)	umask should be 0x01 (my bug).

This revision is now accepted and ready to land.Oct 13 2017, 1:57 PM

Closed by commit rS324598: o Support for Kabylake CPU PMCs (fall down to PMC_CPU_INTEL_SKYLAKE). (authored by br). · Explain WhyOct 13 2017, 3:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

hwpmc/

hwpmc_core.c

25 lines

hwpmc_intel.c

4 lines

pmc_events.h

2 lines

Diff 33953

View Options

head/sys/dev/hwpmc/hwpmc_core.c

View Options

head/sys/dev/hwpmc/hwpmc_intel.c

View Options

head/sys/dev/hwpmc/pmc_events.h

Support for Kabylake PMCClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33953

head/sys/dev/hwpmc/hwpmc_core.c

head/sys/dev/hwpmc/hwpmc_intel.c

head/sys/dev/hwpmc/pmc_events.h

Support for Kabylake PMC
ClosedPublic
Actions

Revision Contents
Changeset List