Page MenuHomeFreeBSD
Differential D12654

Support for Kabylake PMC
ClosedPublic
Actions

Authored by br on Oct 13 2017, 12:30 PM.

Details

Reviewers
emaste
kib
Commits
rS324598: o Support for Kabylake CPU PMCs (fall down to PMC_CPU_INTEL_SKYLAKE).
Summary

Support for 7th Generation Intel® Core (TM)

Test Plan

Tested on ThinkPad X1 Carbon 2017

pmctest.py test passed as well

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

br created this revision.Oct 13 2017, 12:30 PM
br updated this revision to Diff 33945.Oct 13 2017, 12:34 PM

Indicate Intel document number CPU model comes from

emaste added a subscriber: kib.Oct 13 2017, 12:56 PM
kib added a comment.Oct 13 2017, 1:09 PM

Is there a single IAPDESCR in your patch which contains only one of two flags IAP_F_SL and IAP_F_KL ? I mean that SDM lists desktop Skylake and Kabylake core events in the same table.

If IAP_F_KL just duplicates IAP_F_SL, the patch should be reduced to making Kabylake cpuids to fall to the skylake cputype.

br updated this revision to Diff 33948.Oct 13 2017, 1:27 PM

rework patch

kib accepted this revision.Oct 13 2017, 1:57 PM
kib added inline comments.
sys/dev/hwpmc/hwpmc_core.c
723 ↗(On Diff #33948)

umask should be 0x01 (my bug).

This revision is now accepted and ready to land.Oct 13 2017, 1:57 PM
Closed by commit rS324598: o Support for Kabylake CPU PMCs (fall down to PMC_CPU_INTEL_SKYLAKE). (authored by br). · Explain WhyOct 13 2017, 3:02 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
hwpmc/
25 lines
4 lines
2 lines

Diff 33953

View Options

head/sys/dev/hwpmc/hwpmc_core.c

Loading...
View Options

head/sys/dev/hwpmc/hwpmc_intel.c

Loading...
View Options

head/sys/dev/hwpmc/pmc_events.h

Loading...