Page MenuHomeFreeBSD

Support for Kabylake PMC
ClosedPublic

Authored by br on Oct 13 2017, 12:30 PM.

Details

Summary

Support for 7th Generation Intel® Core (TM)

Test Plan

Tested on ThinkPad X1 Carbon 2017

pmctest.py test passed as well

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Indicate Intel document number CPU model comes from

Is there a single IAPDESCR in your patch which contains only one of two flags IAP_F_SL and IAP_F_KL ? I mean that SDM lists desktop Skylake and Kabylake core events in the same table.

If IAP_F_KL just duplicates IAP_F_SL, the patch should be reduced to making Kabylake cpuids to fall to the skylake cputype.

kib added inline comments.
sys/dev/hwpmc/hwpmc_core.c
723 ↗(On Diff #33948)

umask should be 0x01 (my bug).

This revision is now accepted and ready to land.Oct 13 2017, 1:57 PM
This revision was automatically updated to reflect the committed changes.