Page MenuHomeFreeBSD

Add video user for drm devices
ClosedPublic

Authored by kwm on Dec 3 2014, 12:09 PM.
Tags
None
Referenced Files
F103419040: D1260.diff
Sun, Nov 24, 6:52 PM
Unknown Object (File)
Sun, Nov 10, 5:00 PM
Unknown Object (File)
Sun, Nov 10, 4:57 PM
Unknown Object (File)
Oct 22 2024, 7:28 AM
Unknown Object (File)
Oct 1 2024, 2:01 AM
Unknown Object (File)
Sep 28 2024, 1:19 PM
Unknown Object (File)
Sep 28 2024, 9:12 AM
Unknown Object (File)
Sep 27 2024, 11:37 PM
Subscribers

Details

Summary

Make drm 1 and 2 create devices under /dev/dri which are owned by root:video.

I don't know if the group video GID is the correct value, we can always change it.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kwm retitled this revision from to Add video user for drm devices.
kwm updated this object.
kwm edited the test plan for this revision. (Show Details)
kwm added a reviewer: dumbbell.
kwm updated this object.

As discussed on IRC, GID 90 is already taken by firebird.

On Linux, there is no standard GID. Debian uses 44, Gentoo uses 27 for instance.

sys/dev/drm/drmP.h
184 ↗(On Diff #2616)

Please add a comment to recall the group name.

sys/dev/drm2/drmP.h
204 ↗(On Diff #2616)

Likewise.

kwm edited edge metadata.

Use a unused GID, 90 is already in use in ports by firebird.
Add comment in drmP.h

We need to document the change in UPDATING, just in case it conflicts with user-created groups.

I think there is no changes for the user otherwise. The X.Org server runs setuid root, so the group is irrelevant.

dumbbell edited edge metadata.

I repost my last comment, because I forgot to set the "Action" properly.

The comment was: we need to document the change in UPDATING, just in case it conflicts with user-created groups.

This revision now requires changes to proceed.Jun 16 2015, 10:15 AM
kwm edited edge metadata.
kwm updated this object.

Add updating entry

kwm edited edge metadata.

Catch up with src changes.

dumbbell edited edge metadata.
This revision is now accepted and ready to land.Aug 3 2015, 10:06 PM
kwm edited edge metadata.

new UPDATING

This revision now requires review to proceed.Aug 9 2015, 12:06 PM
dumbbell edited edge metadata.
dumbbell added inline comments.
UPDATING
38 ↗(On Diff #7800)

I would say:

If you want to (...)
40 ↗(On Diff #7800)

Instead of hard-coding your username, you could use:

# pw groupmod video -m $USER
This revision now requires changes to proceed.Aug 9 2015, 12:29 PM
kwm edited edge metadata.

UPDATING tweaks

dumbbell edited edge metadata.
This revision is now accepted and ready to land.Aug 9 2015, 12:35 PM
This revision was automatically updated to reflect the committed changes.