Correct sense of crypt(3) NULL checks in init(8) and lock(1)
ClosedPublic
Actions

Authored by cem on Oct 2 2017, 11:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 6, 10:22 PM

	Unknown Object (File)
	Nov 12 2024, 2:26 AM

	Unknown Object (File)
	Oct 28 2024, 8:14 AM

	Unknown Object (File)
	Oct 18 2024, 11:11 PM

	Unknown Object (File)
	Oct 18 2024, 2:08 AM

	Unknown Object (File)
	Oct 1 2024, 1:31 PM

	Unknown Object (File)
	Sep 29 2024, 10:11 PM

	Unknown Object (File)
	Sep 22 2024, 10:25 AM

View All 51 Files

Subscribers

None

Details

Reviewers

jhb

Commits

rS324229: Correct sense of crypt(3) NULL checks in init(8) and lock(1)

Summary

In r231994, an attempt was made to fix crypt(3) failure returns (NULL).
However, instead of treating crypt(3) failure as authentication failure,
some of the changes treated crypt(3) failure as authentication success.
This is wrong.

r324225 fixed this for ppp, which also inspired this review. The other
changes in the 231994 revision were audited for correctness and look ok.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 11849
Build 12187: arc lint + arc unit

Event Timeline

cem created this revision.Oct 2 2017, 11:46 PM

jhb accepted this revision.Oct 3 2017, 12:30 AM

This revision is now accepted and ready to land.Oct 3 2017, 12:30 AM

Closed by commit rS324229: Correct sense of crypt(3) NULL checks in init(8) and lock(1) (authored by cem). · Explain WhyOct 3 2017, 12:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sbin/

init/

init.c

2 lines

usr.bin/

lock/

lock.c

2 lines

Diff 33644

View Options

sbin/init/init.c