Correct sense of crypt(3) NULL checks in init(8) and lock(1)
ClosedPublic
Actions

Authored by cem on Oct 2 2017, 11:46 PM.

Tags

None

Referenced Files

	F149533299: D12571.id33646.diff
	Wed, Mar 25, 2:03 AM

	F149533293: D12571.id33646.diff
	Wed, Mar 25, 2:03 AM

	Unknown Object (File)
	Tue, Mar 24, 3:27 AM

	Unknown Object (File)
	Tue, Mar 24, 2:59 AM

	Unknown Object (File)
	Tue, Mar 24, 1:55 AM

	Unknown Object (File)
	Mon, Mar 23, 12:46 PM

	Unknown Object (File)
	Sun, Mar 22, 11:30 PM

	Unknown Object (File)
	Sun, Mar 22, 7:08 AM

View All Files

Subscribers

None

Details

Reviewers

jhb

Commits

rS324229: Correct sense of crypt(3) NULL checks in init(8) and lock(1)

Summary

In r231994, an attempt was made to fix crypt(3) failure returns (NULL).
However, instead of treating crypt(3) failure as authentication failure,
some of the changes treated crypt(3) failure as authentication success.
This is wrong.

r324225 fixed this for ppp, which also inspired this review. The other
changes in the 231994 revision were audited for correctness and look ok.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cem created this revision.Oct 2 2017, 11:46 PM

jhb accepted this revision.Oct 3 2017, 12:30 AM

This revision is now accepted and ready to land.Oct 3 2017, 12:30 AM

Closed by commit rS324229: Correct sense of crypt(3) NULL checks in init(8) and lock(1) (authored by cem). · Explain WhyOct 3 2017, 12:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

init/

init.c

2 lines

usr.bin/

lock/

lock.c

2 lines

Diff 33646

View Options

head/sbin/init/init.c